r65529 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65528‎ | r65529 | r65530 >
Date:22:53, 25 April 2010
Author:werdna
Status:ok
Tags:
Comment:
HttpFunctions: Fix bug where sslVerifyHost was only added to the CURL options when it would have no effect anyway.
Modified paths:
  • /trunk/phase3/includes/HttpFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HttpFunctions.php
@@ -735,7 +735,7 @@
736736 }
737737 $this->curlOptions[CURLOPT_USERAGENT] = $this->reqHeaders['User-Agent'];
738738
739 - if ( $this->sslVerifyHost ) {
 739+ if ( isset( $this->sslVerifyHost ) ) {
740740 $this->curlOptions[CURLOPT_SSL_VERIFYHOST] = $this->sslVerifyHost;
741741 }
742742

Follow-up revisions

RevisionCommit summaryAuthorDate
r65530MFT r65529werdna22:55, 25 April 2010

Status & tagging log