r65417 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65416‎ | r65417 | r65418 >
Date:01:16, 22 April 2010
Author:aaron
Status:ok
Tags:
Comment:
Removed redundant check if diffButtons()
Modified paths:
  • /trunk/phase3/includes/HistoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HistoryPage.php
@@ -700,7 +700,7 @@
701701 if( !$rev->userCan( Revision::DELETED_TEXT ) ) {
702702 $radio['disabled'] = 'disabled';
703703 $checkmark = array(); // We will check the next possible one
704 - } else if( $counter == 2 || !$this->oldIdChecked ) {
 704+ } else if( !$this->oldIdChecked ) {
705705 $checkmark = array( 'checked' => 'checked' );
706706 $this->oldIdChecked = $id;
707707 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r76698Get ride of $counter in functions calls. Follow up r65417.hashar19:47, 15 November 2010

Status & tagging log