r65156 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65155‎ | r65156 | r65157 >
Date:09:58, 17 April 2010
Author:dale
Status:deferred
Tags:
Comment:
typo in function name
Modified paths:
  • /trunk/extensions/OggHandler/OggHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggHandler_body.php
@@ -215,7 +215,7 @@
216216 return new OggVideoDisplay( $file, $targetFileUrl, $dstUrl, $width, $height, $length, $dstPath, $noIcon );
217217 }
218218
219 - $thumbStatus = $this->gennerateThumb($file, $dstPath,$params, $width, $height);
 219+ $thumbStatus = $this->generateThumb($file, $dstPath, $params, $width, $height);
220220 if( $thumbStatus !== true ) {
221221 return $thumbStatus;
222222 }
@@ -230,7 +230,7 @@
231231 * @param $width The target output width
232232 * @param $height The target output height
233233 */
234 - function gennerateThumb($file, $dstPath, $params, $width, $height){
 234+ function generateThumb($file, $dstPath, $params, $width, $height){
235235 global $wgFFmpegLocation, $wgOggThumbLocation;
236236
237237 $length = $this->getLength( $file );
@@ -316,6 +316,7 @@
317317 // If we did not return an error return true to continue media thum display
318318 return true;
319319 }
 320+
320321 function canRender( $file ) { return true; }
321322 function mustRender( $file ) { return true; }
322323

Follow-up revisions

RevisionCommit summaryAuthorDate
r65889MFT r65563 (and reverted base revisions r65149 and r65156): oggThumb supporttstarling01:11, 4 May 2010

Status & tagging log