r65070 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65069‎ | r65070 | r65071 >
Date:18:11, 15 April 2010
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
Remove the 'editwidth' preference and related code.

I was not able to find any scenario that changed editor behavior anymore in monobook, modern, vector, classic or chick skin.
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/Preferences.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -27,7 +27,6 @@
2828 'tog-editsectiononrightclick',
2929 'tog-showtoc',
3030 'tog-rememberpassword',
31 - 'tog-editwidth',
3231 'tog-watchcreations',
3332 'tog-watchdefault',
3433 'tog-watchmoves',
Index: trunk/phase3/includes/User.php
@@ -62,7 +62,6 @@
6363 'editsectiononrightclick',
6464 'showtoc',
6565 'rememberpassword',
66 - 'editwidth',
6766 'watchcreations',
6867 'watchdefault',
6968 'watchmoves',
Index: trunk/phase3/includes/EditPage.php
@@ -1655,12 +1655,9 @@
16561656 'id' => $name,
16571657 'cols' => $wgUser->getIntOption( 'cols' ),
16581658 'rows' => $wgUser->getIntOption( 'rows' ),
1659 - 'style' => '' // avoid php notices when appending for editwidth preference (appending allows customAttribs['style'] to still work
 1659+ 'style' => '' // avoid php notices when appending preferences (appending allows customAttribs['style'] to still work
16601660 );
16611661
1662 - if ( $wgUser->getOption( 'editwidth' ) )
1663 - $attribs['style'] .= 'width: 100%';
1664 -
16651662 $wgOut->addHTML( Html::textarea( $name, $wikitext, $attribs ) );
16661663 }
16671664
Index: trunk/phase3/includes/DefaultSettings.php
@@ -2724,7 +2724,6 @@
27252725 'editondblclick' => 0,
27262726 'editsection' => 1,
27272727 'editsectiononrightclick' => 0,
2728 - 'editwidth' => 0,
27292728 'enotifminoredits' => 0,
27302729 'enotifrevealaddr' => 0,
27312730 'enotifusertalkpages' => 1,
Index: trunk/phase3/includes/Preferences.php
@@ -736,12 +736,6 @@
737737 'section' => 'editing/advancedediting',
738738 'label-message' => 'tog-editondblclick',
739739 );
740 - $defaultPreferences['editwidth'] =
741 - array(
742 - 'type' => 'toggle',
743 - 'section' => 'editing/advancedediting',
744 - 'label-message' => 'tog-editwidth',
745 - );
746740 $defaultPreferences['showtoolbar'] =
747741 array(
748742 'type' => 'toggle',
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -628,7 +628,6 @@
629629 'tog-editsectiononrightclick' => 'Enable section editing by right clicking on section titles (requires JavaScript)',
630630 'tog-showtoc' => 'Show table of contents (for pages with more than 3 headings)',
631631 'tog-rememberpassword' => 'Remember my login on this computer',
632 -'tog-editwidth' => 'Widen the edit box to fill the entire screen',
633632 'tog-watchcreations' => 'Add pages I create to my watchlist',
634633 'tog-watchdefault' => 'Add pages I edit to my watchlist',
635634 'tog-watchmoves' => 'Add pages I move to my watchlist',

Follow-up revisions

RevisionCommit summaryAuthorDate
r75880Followup r65070, remove last instance of editwidth prefdemon21:19, 2 November 2010

Comments

#Comment by He7d3r (talk | contribs)   16:06, 14 September 2012

Status & tagging log