r65062 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65061‎ | r65062 | r65063 >
Date:13:22, 15 April 2010
Author:catrope
Status:ok
Tags:
Comment:
new-installer: Remove stray <img> tag, improve help buoy CSS so the buoy itself is part of the link
Modified paths:
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)
  • /branches/new-installer/phase3/skins/common/config.css (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/skins/common/config.css
@@ -83,12 +83,15 @@
8484 padding-top: 1em;
8585 }
8686 .config-show-help, .config-hide-help {
 87+ margin-left: 14em;
 88+}
 89+.config-show-help a, .config-hide-help a {
8790 background-image: url(images/help-22.png);
8891 background-position: 0 0;
8992 background-repeat: no-repeat;
90 - line-height: 26px;
91 - margin-left: 14em;
92 - padding-left: 2em;
 93+ display: inline-block;
 94+ height: 26px;
 95+ padding-left: 26px;
9396 }
9497 .config-help-message { display: none; }
9598 .config-hide-help { display: none; }
Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
@@ -514,7 +514,6 @@
515515 "</div>\n" .
516516 "<div class=\"config-hide-help\" id=\"config-hide-help-$id\">\n" .
517517 Xml::openElement( 'a', array( 'href' => "javascript:showHelp($id,false)" ) ) .
518 - "<img src=\"../skins/common/images/help-22.png\" alt=\"$alt\" />&nbsp;&nbsp;" .
519518 wfMsgHtml( 'config-hide-help' ) .
520519 "</a></div>\n</div>\n";
521520 }

Status & tagging log