r65061 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65060‎ | r65061 | r65062 >
Date:13:07, 15 April 2010
Author:catrope
Status:ok
Tags:
Comment:
new-installer: Make Help icons look nicer by implementing them as background-images rather than <img> tags
Modified paths:
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)
  • /branches/new-installer/phase3/skins/common/config.css (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/skins/common/config.css
@@ -83,7 +83,12 @@
8484 padding-top: 1em;
8585 }
8686 .config-show-help, .config-hide-help {
 87+ background-image: url(images/help-22.png);
 88+ background-position: 0 0;
 89+ background-repeat: no-repeat;
 90+ line-height: 26px;
8791 margin-left: 14em;
 92+ padding-left: 2em;
8893 }
8994 .config-help-message { display: none; }
9095 .config-hide-help { display: none; }
@@ -148,4 +153,4 @@
149154 .config-plainlink a {
150155 background: none !important;
151156 padding: 0 !important;
152 -}
\ No newline at end of file
 157+}
Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
@@ -507,7 +507,6 @@
508508 "<div class=\"config-help-wrapper\">\n" .
509509 "<div class=\"config-show-help\" id=\"config-show-help-$id\">\n" .
510510 Xml::openElement( 'a', array( 'href' => "javascript:showHelp($id,true)" ) ) .
511 - "<img src=\"../skins/common/images/help-22.png\" alt=\"$alt\" />&nbsp;&nbsp;" .
512511 wfMsgHtml( 'config-show-help' ) .
513512 "</a></div>\n" .
514513 "<div class=\"config-help-message\" id=\"config-help-message-$id\">\n" .

Status & tagging log