r65059 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r65058‎ | r65059 | r65060 >
Date:12:47, 15 April 2010
Author:nikerabbit
Status:resolved (Comments)
Tags:
Comment:
Remove jobqueue length from the user interface

It causes more confusion than it is worth:
* The figures are essentially random, so it does not help to detect problems
* There shouldn't be any problems with default configuration anyway
* The number is still accessible by other means
Modified paths:
  • /trunk/phase3/includes/specials/SpecialStatistics.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1424,7 +1424,6 @@
14251425 'statistics-edits-average',
14261426 'statistics-views-total',
14271427 'statistics-views-peredit',
1428 - 'statistics-jobqueue',
14291428 'statistics-users',
14301429 'statistics-users-active',
14311430 'statistics-users-active-desc',
Index: trunk/phase3/includes/specials/SpecialStatistics.php
@@ -153,11 +153,9 @@
154154 array( 'class' => 'mw-statistics-edits' ) ) .
155155 $this->formatRow( wfMsgExt( 'statistics-edits-average', array( 'parseinline' ) ),
156156 $wgLang->formatNum( sprintf( '%.2f', $this->total ? $this->edits / $this->total : 0 ) ),
157 - array( 'class' => 'mw-statistics-edits-average' ) ) .
158 - $this->formatRow( wfMsgExt( 'statistics-jobqueue', array( 'parseinline' ) ),
159 - $wgLang->formatNum( $this->numJobs ),
160 - array( 'class' => 'mw-statistics-jobqueue' ) );
 157+ array( 'class' => 'mw-statistics-edits-average' ) );
161158 }
 159+
162160 private function getUserStats() {
163161 global $wgLang, $wgUser, $wgRCMaxAge;
164162 $sk = $wgUser->getSkin();
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2321,7 +2321,6 @@
23222322 'statistics-edits-average' => 'Average edits per page',
23232323 'statistics-views-total' => 'Views total',
23242324 'statistics-views-peredit' => 'Views per edit',
2325 -'statistics-jobqueue' => '[http://www.mediawiki.org/wiki/Manual:Job_queue Job queue] length',
23262325 'statistics-users' => 'Registered [[Special:ListUsers|users]]',
23272326 'statistics-users-active' => 'Active users',
23282327 'statistics-users-active-desc' => 'Users who have performed an action in the last {{PLURAL:$1|day|$1 days}}',

Follow-up revisions

RevisionCommit summaryAuthorDate
r75272Remove action=raw from Special:Statistics. We wanted to keep it for back-comp...demon17:04, 23 October 2010

Comments

#Comment by Hashar (talk | contribs)   12:23, 21 October 2010

Marking fixme: Removal of jobs display is not completet. There are still occurrences of numJobs in SpecialStatistics.php !

About the removal, maybe SiteStats::jobs() could be made to return an array of jobs for each DB_SLAVE ? That would make the output less confusing :)

#Comment by Nikerabbit (talk | contribs)   21:08, 22 October 2010

I intentionally removed only the part causing most confusion to users.

#Comment by 😂 (talk | contribs)   17:05, 23 October 2010

See r75272.

#Comment by Hashar (talk | contribs)   17:08, 23 October 2010

Thanks ^demon .

Status & tagging log