r64955 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r64954‎ | r64955 | r64956 >
Date:10:23, 12 April 2010
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Partial fix to bug 23167

Api doesn't watch new file on upload (and didn't previously). Now watches on creation
Modified paths:
  • /trunk/phase3/includes/api/ApiUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiUpload.php
——@@ -248,7 +248,7 @@
249249 }
250250
251251 $file = $this->mUpload->getLocalFile();
252 - $watch = $this->getWatchlistValue( $params['watchlist'], $file->getTitle() );
 252+ $watch = $this->getWatchlistValue( $params['watchlist'], $file->getTitle() ) || $wgUser->getOption( 'watchcreations' );
253253
254254 // Deprecated parameters
255255 if ( $this->mParams['watch'] ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r64957(bug 23167) Check the watch checkbox by default if the watchcreations prefere...btongminh10:40, 12 April 2010
r64958Revert r64955...reedy10:44, 12 April 2010
r64963RELEASE-NOTES for bug 23167 r64957 and r94958reedy15:56, 12 April 2010
r65684MFT r64957, bug 23167: respect the watchcreations user preference on uploadtstarling06:36, 30 April 2010

Comments

#Comment by Reedy (talk | contribs)   10:35, 12 April 2010

Followup reversion coming to this to fix other noticed bug.

Status & tagging log