r64886 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64885‎ | r64886 | r64887 >
Date:16:44, 10 April 2010
Author:happy-melon
Status:ok (Comments)
Tags:
Comment:
Follow-up to r64407 - a perfect example of why we encourage using braces for one-line conditionals in the first place.
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -933,9 +933,9 @@
934934 $flag = 0;
935935 } else {
936936 $flag = Parser::PTD_FOR_INCLUSION;
 937+ }
937938 $dom = $this->preprocessToDom( $text, $flag );
938939 $text = $frame->expand( $dom );
939 - }
940940 } else {
941941 # if $frame is not provided, then use old-style replaceVariables
942942 $text = $this->replaceVariables( $text );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64407Overhaul code format to coding conventions.happy-melon21:20, 30 March 2010

Comments

#Comment by Platonides (talk | contribs)   18:00, 10 April 2010

This fixes the <poem> regression introduced in r64407.

#Comment by Platonides (talk | contribs)   18:03, 10 April 2010

(read the new line as <poem>)

Status & tagging log