r64856 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r64855‎ | r64856 | r64857 >
Date:07:07, 10 April 2010
Author:philip
Status:reverted (Comments)
Tags:
Comment:
Follow up r64851. Remove $wgOut.
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
——@@ -303,7 +303,7 @@
304304 * to internalParse() which does all the real work.
305305 */
306306
307 - global $wgUseTidy, $wgAlwaysUseTidy, $wgContLang, $wgDisableLangConversion, $wgDisableTitleConversion, $wgUser, $wgRequest, $wgOut;
 307+ global $wgUseTidy, $wgAlwaysUseTidy, $wgContLang, $wgDisableLangConversion, $wgDisableTitleConversion, $wgUser, $wgRequest;
308308 $fname = __METHOD__.'-' . wfGetCaller();
309309 wfProfileIn( __METHOD__ );
310310 wfProfileIn( $fname );
——@@ -386,7 +386,7 @@
387387 if ( $convruletitle ) {
388388 $this->mOutput->setTitleText( $convruletitle );
389389 } else {
390 - $wgOut->setPageTitle( $wgContLang->convert( $wgOut->getPageTitle(), true ) );
 390+ $this->mOutput->setTitleText( $wgContLang->convert( $title->getPrefixedText(), true ) );
391391 }
392392 }
393393

Follow-up revisions

RevisionCommit summaryAuthorDate
r649291.16wmf4: Merge langconverter fixes from trunk: r64851, r64856, r64876, r6489...catrope12:01, 11 April 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64851Fix bug 23115 again. Follow up r64821, r64823 and r64827. Rewrite the convert...philip05:46, 10 April 2010

Comments

#Comment by Platonides (talk | contribs)   13:33, 10 April 2010

This breaks again displaytitle. There are a couple of parsertests affected, so it's easy to check.

#Comment by Liangent (talk | contribs)   04:26, 30 July 2010

Don't mark it 'resolved' yourself.

#Comment by Platonides (talk | contribs)   21:06, 17 October 2010

Reverted by r64876

Status & tagging log