r64837 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r64836‎ | r64837 | r64838 >
Date:22:12, 9 April 2010
Author:catrope
Status:ok
Tags:
Comment:
Fix another instance of the result of User::newFromName() being compared with null, fixes fatal errors
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
——@@ -708,7 +708,7 @@
709709 return;
710710 }
711711 $u = User::newFromName( $this->mName );
712 - if( is_null( $u ) ) {
 712+ if( !$u instanceof User ) {
713713 $this->mainLoginForm( wfMsg( 'noname' ) );
714714 return;
715715 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r648381.16wmf4: MFT r64837catrope22:15, 9 April 2010
r65360MFT r63490, r64837, r64860, r64862: bug fixes for callers of User::newFromNam...tstarling09:30, 21 April 2010

Status & tagging log