r64802 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64801‎ | r64802 | r64803 >
Date:14:38, 9 April 2010
Author:churchofemacs
Status:ok
Tags:
Comment:
fixing bug 23113 (introduced in r60945) which breaks show/hide links in diffs
Modified paths:
  • /trunk/phase3/includes/diff/DifferenceInterface.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceInterface.php
@@ -395,8 +395,8 @@
396396 } else {
397397 $query = array(
398398 'type' => 'revision',
399 - 'target' => $this->mOldRev->mTitle->getPrefixedDbkey(),
400 - 'ids' => $this->mOldRev->getId()
 399+ 'target' => $rev->mTitle->getPrefixedDbkey(),
 400+ 'ids' => $rev->getId()
401401 );
402402 $link = $sk->revDeleteLink( $query,
403403 $rev->isDeleted( Revision::DELETED_RESTRICTED ), $canHide );

Follow-up revisions

RevisionCommit summaryAuthorDate
r648031.16wmf4: MFT r64802catrope14:45, 9 April 2010
r65364MFT r64802, bug 23113: Fixed title in the show/hide links on diff pages.tstarling09:52, 21 April 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r60945Refactored duplication into revisionDeleteLink()aaron21:35, 11 January 2010

Status & tagging log