r64673 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64672‎ | r64673 | r64674 >
Date:22:15, 6 April 2010
Author:jeroendedauw
Status:deferred (Comments)
Tags:
Comment:
Changes for 0.6 - bugfix
Modified paths:
  • /trunk/extensions/Maps/Maps_Mapper.php (modified) (history)
  • /trunk/extensions/Maps/Maps_Settings.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Maps_Mapper.php
@@ -90,17 +90,7 @@
9191 // If they don't, a fatal error will occur later on.
9292 if ( $shouldChange ) {
9393 if ( array_key_exists( $feature, $egMapsDefaultServices ) ) {
94 - if ( is_array( $egMapsDefaultServices[$feature] ) ) {
95 - if ( array_key_exists( $subfeature, $egMapsDefaultServices[$feature] ) ) {
96 - $service = $egMapsDefaultServices[$feature][$subfeature];
97 - }
98 - else {
99 - $service = $egMapsDefaultService;
100 - }
101 - }
102 - else {
103 - $service = $egMapsDefaultServices[$feature];
104 - }
 94+ $service = $egMapsDefaultServices[$feature];
10595 }
10696 else {
10797 $service = $egMapsDefaultService;
Index: trunk/extensions/Maps/Maps_Settings.php
@@ -92,10 +92,8 @@
9393 # Each service needs to be enabled, if not, the first one from the available services will be taken.
9494 # Note: The default service needs to be available for the feature you set it for, since it's used as a fallback mechanism.
9595 $egMapsDefaultServices = array(
96 - 'pf' => array(
97 - 'display_point' => 'googlemaps2',
98 - 'display_map' => 'googlemaps2'
99 - )
 96+ 'display_point' => 'googlemaps2',
 97+ 'display_map' => 'googlemaps2'
10098 );
10199
102100

Follow-up revisions

RevisionCommit summaryAuthorDate
r64703Follow up to r64673jeroendedauw14:32, 7 April 2010
r64704Follow up to r64673jeroendedauw14:32, 7 April 2010

Comments

#Comment by Raymond (talk | contribs)   06:05, 7 April 2010

PHP Notice: Undefined index: pf in /www/w/extensions/Maps/ParserFunctions/Maps_ParserFunctions.php on line 56

Status & tagging log