r64509 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64508‎ | r64509 | r64510 >
Date:23:27, 1 April 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
(bug 22935) image/x-ms-bmp mime type added for BMP files
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/MimeMagic.php (modified) (history)
  • /trunk/phase3/includes/mime.info (modified) (history)
  • /trunk/phase3/includes/mime.types (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/MimeMagic.php
@@ -80,7 +80,7 @@
8181 audio/x-wav [AUDIO]
8282 audio/mp3 audio/mpeg [AUDIO]
8383 application/ogg audio/ogg video/ogg [MULTIMEDIA]
84 -image/x-bmp image/bmp [BITMAP]
 84+image/x-bmp image/x-ms-bmp image/bmp [BITMAP]
8585 image/gif [BITMAP]
8686 image/jpeg [BITMAP]
8787 image/png [BITMAP]
Index: trunk/phase3/includes/mime.types
@@ -85,6 +85,7 @@
8686 image/vnd.wap.wbmp wbmp
8787 image/x-cmu-raster ras
8888 image/x-icon ico
 89+image/x-ms-bmp
8990 image/x-portable-anymap pnm
9091 image/x-portable-bitmap pbm
9192 image/x-portable-graymap pgm
Index: trunk/phase3/includes/mime.info
@@ -16,7 +16,7 @@
1717 image/x-rgb [BITMAP]
1818 image/x-portable-pixmap [BITMAP]
1919 image/x-portable-graymap image/x-portable-greymap [BITMAP]
20 -image/x-bmp image/bmp application/x-bmp application/bmp [BITMAP]
 20+image/x-bmp image/x-ms-bmp image/bmp application/x-bmp application/bmp [BITMAP]
2121 image/x-photoshop image/psd image/x-psd image/photoshop [BITMAP]
2222 image/vnd.djvu image/x.djvu image/x-djvu [BITMAP]
2323
Index: trunk/phase3/RELEASE-NOTES
@@ -69,7 +69,8 @@
7070 anonymous users instead of null.
7171 * (bug 22627) Remove PHP notice when deleting a page only hidden users edited.
7272 * (bug 21520) Anonymous previews now also gives a warning about not being
73 -logged in (anonpreviewwarning).
 73+ logged in (anonpreviewwarning).
 74+* (bug 22935) image/x-ms-bmp mime type added for BMP files
7475
7576 === API changes in 1.17 ===
7677 * (bug 22738) Allow filtering by action type on query=logevent

Follow-up revisions

RevisionCommit summaryAuthorDate
r65650Followup r64509, need bmp after image/x-ms-bmpdemon10:24, 29 April 2010
r65931MFT r64509, r65650, r65816, fix .bmp and .oga MIME type detectiontstarling01:47, 5 May 2010

Comments

#Comment by TheDJ (talk | contribs)   14:15, 27 April 2010

Shouldn't there be 'bmp' behind the image/x-ms-bmp in includes/mime.types ?

#Comment by 😂 (talk | contribs)   10:25, 29 April 2010

Done in r65650.

Status & tagging log