r64465 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r64464‎ | r64465 | r64466 >
Date:00:35, 1 April 2010
Author:mah
Status:ok (Comments)
Tags:
Comment:
follow up r64454 — change comment style
Modified paths:
  • /trunk/phase3/includes/api/ApiBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiBase.php
——@@ -475,7 +475,7 @@
476476 $params = $this->getFinalParams();
477477 $results = array();
478478
479 - if($params) { /* getFinalParams() can return false */
 479+ if($params) { // getFinalParams() can return false
480480 foreach ( $params as $paramName => $paramSettings ) {
481481 $results[$paramName] = $this->getParameterFromSettings( $paramName, $paramSettings, $parseLimit );
482482 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r64480followup r64465 — make happy-melon happymah11:25, 1 April 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64454Get rid of E_STRICT messagemah19:50, 31 March 2010

Comments

#Comment by Happy-melon (talk | contribs)   10:23, 1 April 2010

You still need spaces around the if statement. See Manual:Coding conventions. Should be 

+		if ( $params ) { // getFinalParams() can return false
#Comment by MarkAHershberger (talk | contribs)   11:26, 1 April 2010

see r64480

#Comment by Happy-melon (talk | contribs)   11:31, 1 April 2010

Hehe.

Status & tagging log