r64440 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64439‎ | r64440 | r64441 >
Date:15:26, 31 March 2010
Author:gurch
Status:resolved (Comments)
Tags:
Comment:
(bug 22290) Inconsistent presence of "comment" field in prop=revisions versus list=recentchanges
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryRevisions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRevisions.php
@@ -392,15 +392,14 @@
393393 $vals['commenthidden'] = '';
394394 } else {
395395 $comment = $revision->getComment();
396 - if ( strval( $comment ) !== '' ) {
397 - if ( $this->fld_comment ) {
398 - $vals['comment'] = $comment;
399 - }
 396+
 397+ if ( $this->fld_comment ) {
 398+ $vals['comment'] = $comment;
 399+ }
400400
401 - if ( $this->fld_parsedcomment ) {
402 - global $wgUser;
403 - $vals['parsedcomment'] = $wgUser->getSkin()->formatComment( $comment, $title );
404 - }
 401+ if ( $this->fld_parsedcomment ) {
 402+ global $wgUser;
 403+ $vals['parsedcomment'] = $wgUser->getSkin()->formatComment( $comment, $title );
405404 }
406405 }
407406 }
Index: trunk/phase3/RELEASE-NOTES
@@ -70,13 +70,15 @@
7171 * (bug 21520) Anonymous previews now also gives a warning about not being
7272 logged in (anonpreviewwarning).
7373
74 -== API changes in 1.17 ==
 74+=== API changes in 1.17 ===
7575 * (bug 22738) Allow filtering by action type on query=logevent
7676 * (bug 22764) uselang parameter for action=parse
7777 * (bug 22944) API: watchlist options are inconsistent
7878 * (bug 22339) "Go" result should be available through the API
7979 * (bug 22868) don't list infinite block expiry date as "now" in API logevents
80 -
 80+* (bug 22290) Inconsistent presence of "comment" field in prop=revisions
 81+ versus list=recentchanges
 82+
8183 === Languages updated in 1.17 ===
8284
8385 == Compatibility ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r64449follow up r64440: specify in release notes exactly what changedgurch18:54, 31 March 2010

Comments

#Comment by Bryan (talk | contribs)   17:14, 31 March 2010

While the release note specifies what is fixed, it does not specify how it was fixed, which is the most useful information. This is a visible end user change, but without reading the diff the user has no idea what the actual change is it can expect.

#Comment by Gurch (talk | contribs)   18:54, 31 March 2010

addressed in r64449

Status & tagging log