r64172 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r64171‎ | r64172 | r64173 >
Date:19:39, 25 March 2010
Author:aaron
Status:ok
Tags:
Comment:
* Improved diff notice after edit (for reviewers)
* Removed useless URL param from r64170
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/OldReviewedPages_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php
@@ -55,7 +55,7 @@
5656 'revreview-diff-toggle-title' => 'Toggle display of pending changes to the published version',
5757 'revreview-log-toggle-show' => '(show stability log)',
5858 'revreview-log-details-show' => '(show details)',
59 - 'review-diff2stable' => 'View pending changes to published version',
 59+ 'review-diff2stable' => 'View all pending changes',
6060 'review-logentry-app' => 'reviewed a version of [[$1]]',
6161 'review-logentry-dis' => 'deprecated a version of [[$1]]',
6262 'review-logentry-id' => 'revision: $2',
@@ -171,6 +171,9 @@
172172
173173 Please hit the "back" button in your browser and try again.',
174174 'revreview-update' => 'Please [[{{MediaWiki:Validationpage}}|review]] any pending changes \'\'(shown below)\'\' made to the published version.',
 175+ 'revreview-update-edited' => 'When you edited this page, some \'\'other\'\' edits were already pending review.
 176+
 177+To publish your changes, please [[{{MediaWiki:Validationpage}}|review]] \'\'all\'\' the pending changes \'\'(shown below)\'\'.',
175178 'revreview-update-includes' => '\'\'\'Some templates/files were updated:\'\'\'',
176179 'revreview-update-use' => '\'\'\'NOTE:\'\'\' The published version of each of these templates/files is used in the published version of this page.',
177180 'revreview-visibility' => '\'\'\'This page has an updated [[{{MediaWiki:Validationpage}}|published version]]; page stability settings can be [{{fullurl:{{#Special:Stabilization}}|page={{FULLPAGENAMEE}}}} configured].\'\'\'',
Index: trunk/extensions/FlaggedRevs/specialpages/OldReviewedPages_body.php
@@ -205,8 +205,8 @@
206206
207207 $title = Title::newFromRow( $row );
208208 $link = $this->skin->makeKnownLinkObj( $title );
209 - $hist = $this->skin->makeKnownLinkObj( $title, wfMsgHtml( 'hist' ),
210 - 'action=history&reviewing=1' );
 209+ $hist = $this->skin->makeKnownLinkObj( $title,
 210+ wfMsgHtml( 'hist' ), 'action=history' );
211211 $stxt = ChangesList::showCharacterDifference( $row->rev_len, $row->page_len );
212212 $review = $this->skin->makeKnownLinkObj( $title,
213213 wfMsg( 'oldreviewed-diff' ),
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -157,6 +157,7 @@
158158 return true;
159159 }
160160
 161+ // Mark when an unreviewed page is being reviewed
161162 public static function maybeMarkUnderReview( $article, $user, $request ) {
162163 if( !$user->isAllowed( 'review' ) ) {
163164 return true; // user cannot review
Index: trunk/extensions/FlaggedRevs/FlaggedArticleView.php
@@ -1223,7 +1223,14 @@
12241224 # Only those if there is something to actually review.
12251225 if ( $newRev->getId() > $oldRev->getId() ) {
12261226 # "Please review" notice...
1227 - $changeDiv = wfMsgExt( 'revreview-update', 'parse' );
 1227+ $msg = 'revreview-update';
 1228+ if( $wgRequest->getInt( 'shownotice' )
 1229+ && $newRev->isCurrent()
 1230+ && $newRev->getRawUserText() == $wgUser->getName() )
 1231+ {
 1232+ $msg = 'revreview-update-edited'; // Reviewer just edited
 1233+ }
 1234+ $changeDiv = wfMsgExt( $msg, 'parse' );
12281235 if ( count( $changeList ) ) {
12291236 # Add include change list...
12301237 $changeDiv .= '<p>' .
@@ -1451,7 +1458,7 @@
14521459 if ( $frev->userCanSetFlags() ) {
14531460 $extraQuery .= $extraQuery ? '&' : '';
14541461 // Override diffonly setting to make sure the content is shown
1455 - $extraQuery .= 'oldid='.intval($frev->getRevId()).'&diff=cur&diffonly=0';
 1462+ $extraQuery .= 'oldid='.$frev->getRevId().'&diff=cur&diffonly=0&shownotice=1';
14561463 // ...otherwise, go to the current revision after completing an edit.
14571464 // This allows for users to immediately see their changes.
14581465 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r64173MFT r63940-r64172aaron19:43, 25 March 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64170* Added history links to OldReviewedPages...aaron19:31, 25 March 2010

Status & tagging log