r63724 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63723‎ | r63724 | r63725 >
Date:03:40, 14 March 2010
Author:werdna
Status:deferred
Tags:
Comment:
LiquidThreads: Resolution for r62721, plural support and date/time split
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/View.php (modified) (history)
  • /trunk/extensions/LiquidThreads/i18n/Lqt.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/i18n/Lqt.i18n.php
@@ -158,7 +158,7 @@
159159 'lqt-history-comment' => 'Comment',
160160 'lqt-history-thread' => 'Thread',
161161 'lqt-thread-edited-author' => "Edited by author.<br />\nLast edit: $1",
162 - 'lqt-thread-edited-others' => "Edited by {{PLURAL:$2|another user|$2 other users}}.<br />\nLast edit: $1",
 162+ 'lqt-thread-edited-others' => "Edited by {{PLURAL:$2|another user|$2 users}}.<br />\nLast edit: $1",
163163 'lqt-header-actions' => 'Actions',
164164 'lqt_summarize_link' => 'Summarize',
165165 'lqt-summarize-intro' => 'Please summarize the below thread in the editing box.
Index: trunk/extensions/LiquidThreads/classes/View.php
@@ -1406,6 +1406,8 @@
14071407 Threads::EDITED_BY_OTHERS => 'others' );
14081408 $lastEdit = $thread->root()->getTimestamp();
14091409 $lastEdit = $wgLang->timeanddate( $lastEdit, true );
 1410+ $lastEditTime = $wgLang->time( $lastEdit, true );
 1411+ $lastEditDate = $wgLang->date( $lastEdit, true );
14101412 $editors = '';
14111413 $editorCount = 0;
14121414
@@ -1428,7 +1430,8 @@
14291431 $editedBy = $ebLookup[$editedFlag];
14301432 $editedNotice = wfMsgExt( 'lqt-thread-edited-' . $editedBy,
14311433 array( 'parseinline' ),
1432 - array( $lastEdit, $editorCount ) );
 1434+ array( $lastEdit, $editorCount, $lastEditTime,
 1435+ $lastEditDate ) );
14331436 $editedNotice = str_replace( '$3', $editors, $editedNotice );
14341437 $infoElements[] = Xml::tags( 'div', array( 'class' =>
14351438 'lqt-thread-toolbar-edited-' . $editedBy ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r63733Follow-up r63724: Update for translatewikiraymond06:29, 14 March 2010
r63746Follow-up r63724/r63733: Update for translatewiki...raymond17:38, 14 March 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62721LiquidThreads: Change around edited display to be less obtrusive and more inf...werdna20:42, 19 February 2010

Status & tagging log