r63625 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63624‎ | r63625 | r63626 >
Date:01:36, 12 March 2010
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Added some CSS rules to make lists of parameters in a template dialog look nicer.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.min.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/wikiEditor.dialogs.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -22,18 +22,18 @@
2323 array( 'src' => 'css/vector.collapsibleNav.css', 'version' => 7 ),
2424 array( 'src' => 'css/vector.footerCleanup.css', 'version' => 1 ),
2525 array( 'src' => 'css/wikiEditor.css', 'version' => 12 ),
26 - array( 'src' => 'css/wikiEditor.dialogs.css', 'version' => 26 ),
 26+ array( 'src' => 'css/wikiEditor.dialogs.css', 'version' => 27 ),
2727 array( 'src' => 'css/wikiEditor.preview.css', 'version' => 1 ),
2828 array( 'src' => 'css/wikiEditor.toc.css', 'version' => 30 ),
2929 array( 'src' => 'css/wikiEditor.toolbar.css', 'version' => 11 ),
3030 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3131 ),
3232 'combined' => array(
33 - array( 'src' => 'css/combined.css', 'version' => 76 ),
 33+ array( 'src' => 'css/combined.css', 'version' => 77 ),
3434 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3535 ),
3636 'minified' => array(
37 - array( 'src' => 'css/combined.min.css', 'version' => 76 ),
 37+ array( 'src' => 'css/combined.min.css', 'version' => 77 ),
3838 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3939 ),
4040 )
Index: trunk/extensions/UsabilityInitiative/css/wikiEditor.dialogs.css
@@ -242,8 +242,13 @@
243243 border-bottom: dashed 1px silver;
244244 clear: both;
245245 }
 246+.wikiEditor-template-dialog-fields .wikiEditor-template-dialog-field-wrapper:first-child {
 247+ padding-top: 0;
 248+}
 249+.wikiEditor-template-dialog-fields .wikiEditor-template-dialog-field-wrapper:last-child {
 250+ border-bottom: none;
 251+}
246252
247 -
248253 /* Self Clearing Floats */
249254 .wikieditor-toolbar-table-dimension-fields:after,
250255 .wikieditor-toolbar-dialog-wrapper:after {
Index: trunk/extensions/UsabilityInitiative/css/combined.css
@@ -489,8 +489,13 @@
490490 border-bottom: dashed 1px silver;
491491 clear: both;
492492 }
 493+.wikiEditor-template-dialog-fields .wikiEditor-template-dialog-field-wrapper:first-child {
 494+ padding-top: 0;
 495+}
 496+.wikiEditor-template-dialog-fields .wikiEditor-template-dialog-field-wrapper:last-child {
 497+ border-bottom: none;
 498+}
493499
494 -
495500 /* Self Clearing Floats */
496501 .wikieditor-toolbar-table-dimension-fields:after,
497502 .wikieditor-toolbar-dialog-wrapper:after {
Index: trunk/extensions/UsabilityInitiative/css/combined.min.css
@@ -466,6 +466,12 @@
467467 border-bottom:dashed 1px silver;
468468 clear:both;
469469 }
 470+.wikiEditor-template-dialog-fields .wikiEditor-template-dialog-field-wrapper:first-child{
 471+padding-top:0;
 472+}
 473+.wikiEditor-template-dialog-fields .wikiEditor-template-dialog-field-wrapper:last-child{
 474+border-bottom:none;
 475+}
470476 .wikieditor-toolbar-table-dimension-fields:after,
471477 .wikieditor-toolbar-dialog-wrapper:after{
472478 visibility:hidden;

Comments

#Comment by Catrope (talk | contribs)   13:08, 12 March 2010
+.wikiEditor-template-dialog-fields .wikiEditor-template-dialog-field-wrapper:first-child {
+	padding-top: 0;
+}
+.wikiEditor-template-dialog-fields .wikiEditor-template-dialog-field-wrapper:last-child {
+	border-bottom: none;
+}

:first-child is not or poorly (i.e. not for dynamically added children) supported in older browsers, and :last-child is not supported in IE at all, see http://quirksmode.org/css/contents.html

#Comment by Trevor Parscal (WMF) (talk | contribs)   20:10, 12 March 2010

Inddeed, but since we are targeting FF3 only, this should be no problem.

Status & tagging log