r63622 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63621‎ | r63622 | r63623 >
Date:00:34, 12 March 2010
Author:tstarling
Status:ok
Tags:
Comment:
Reverted r60743 and related: Lucene already does some fairly complex normalisation on input text, and doesn't really need MediaWiki to help with that. If there is a bug in Lucene to do with full-width latin characters, then we can fix it in Lucene.
Modified paths:
  • /branches/REL1_16/extensions/MWSearch/MWSearchUpdater.php (modified) (history)
  • /branches/REL1_16/extensions/MWSearch/MWSearch_body.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/extensions/MWSearch/MWSearchUpdater.php
@@ -20,8 +20,6 @@
2121 * @static
2222 */
2323 function updatePage( $dbname, $title, $text ) {
24 - global $wgContLang;
25 - $text = $wgContLang->normalizeForSearch( $text );
2624 return MWSearchUpdater::sendRPC( 'searchupdater.updatePage',
2725 array( $dbname, $title, $text ) );
2826 }
Index: branches/REL1_16/extensions/MWSearch/MWSearch_body.php
@@ -9,8 +9,6 @@
1010 * @access public
1111 */
1212 function searchText( $term ) {
13 - global $wgContLang;
14 - $term = $wgContLang->normalizeForSearch( $term );
1513 return LuceneSearchSet::newFromQuery( isset($this->related)? 'related' : 'search',
1614 $term, $this->namespaces, $this->limit, $this->offset, $this->searchingEverything() );
1715 }
@@ -749,4 +747,4 @@
750748 return new LuceneResult( $group, $this->mMethod );
751749 }
752750
753 -}
\ No newline at end of file
 751+}

Follow-up revisions

RevisionCommit summaryAuthorDate
r63623As in r63622, reverted r60743 and related: Lucene doesn't need any language-s...tstarling00:39, 12 March 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r607431. Add conditions to stripForSearch for LuceneSearch / MWSearch....philip19:51, 6 January 2010

Status & tagging log