r63394 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63393‎ | r63394 | r63395 >
Date:14:43, 8 March 2010
Author:catrope
Status:ok
Tags:
Comment:
Build preload l10ncache after running hooks, not before, so extension changes (by e.g. LocalisationUpdate) to preloaded messages get picked up.
Modified paths:
  • /trunk/phase3/includes/LocalisationCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LocalisationCache.php
@@ -586,9 +586,6 @@
587587 $allData['defaultUserOptionOverrides'] = array();
588588 }
589589
590 - # Set the preload key
591 - $allData['preload'] = $this->buildPreload( $allData );
592 -
593590 # Set the list keys
594591 $allData['list'] = array();
595592 foreach ( self::$splitKeys as $key ) {
@@ -603,6 +600,9 @@
604601 'Check that your languages/messages/MessagesEn.php file is intact.' );
605602 }
606603
 604+ # Set the preload key
 605+ $allData['preload'] = $this->buildPreload( $allData );
 606+
607607 # Save to the process cache and register the items loaded
608608 $this->data[$code] = $allData;
609609 foreach ( $allData as $key => $item ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r63410Backport r63394 (Fix bug in LocalisationCache preventing extensions from chan...catrope20:06, 8 March 2010
r63417MFT r63394catrope21:06, 8 March 2010

Status & tagging log