r63380 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63379‎ | r63380 | r63381 >
Date:02:03, 8 March 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
Only show detected databases on DB settings page.
Modified paths:
  • /branches/new-installer/phase3/includes/installer/Installer.php (modified) (history)
  • /branches/new-installer/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/WebInstaller.php
@@ -907,7 +907,7 @@
908908 $types = "<ul class=\"config-settings-block\">\n";
909909 $settings = '';
910910 $defaultType = $this->getVar( 'wgDBtype' );
911 - foreach ( $this->parent->getDBTypes() as $type ) {
 911+ foreach ( $this->parent->getVar( '_CompiledDBs' ) as $type ) {
912912 $installer = $this->parent->getDBInstaller( $type );
913913 $encType = Xml::encodeJsVar( $type );
914914 $types .=
Index: branches/new-installer/phase3/includes/installer/Installer.php
@@ -354,7 +354,7 @@
355355 $db = $this->getDBInstaller( $name );
356356 $readableName = wfMsg( 'config-type-' . $name );
357357 if ( $db->isCompiled() ) {
358 - $compiledDBs[$name] = true;
 358+ $compiledDBs[] = $name;
359359 $goodNames[] = $readableName;
360360 }
361361 $allNames[] = $readableName;

Comments

#Comment by Tim Starling (talk | contribs)   05:43, 30 June 2010

Could you add a help box listing all the DBMSes that are supported by MediaWiki and explaining how to get them into PHP?

#Comment by 😂 (talk | contribs)   22:12, 22 August 2010

Did this in r71441, r71449.

Status & tagging log