r63340 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63339‎ | r63340 | r63341 >
Date:20:49, 6 March 2010
Author:ialex
Status:ok
Tags:
Comment:
* (bug 22747) "Reveal my e-mail address in notification e-mails" preference is now only displayed when relevant
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Preferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
@@ -433,14 +433,17 @@
434434 'label-message' => 'tog-enotifminoredits',
435435 'disabled' => $disableEmailPrefs,
436436 );
 437+ global $wgEnotifRevealEditorAddress;
 438+ if ( $wgEnotifRevealEditorAddress ) {
 439+ $defaultPreferences['enotifrevealaddr'] =
 440+ array(
 441+ 'type' => 'toggle',
 442+ 'section' => 'personal/email',
 443+ 'label-message' => 'tog-enotifrevealaddr',
 444+ 'disabled' => $disableEmailPrefs,
 445+ );
 446+ }
437447 }
438 - $defaultPreferences['enotifrevealaddr'] =
439 - array(
440 - 'type' => 'toggle',
441 - 'section' => 'personal/email',
442 - 'label-message' => 'tog-enotifrevealaddr',
443 - 'disabled' => $disableEmailPrefs,
444 - );
445448 }
446449 }
447450
Index: trunk/phase3/RELEASE-NOTES
@@ -40,6 +40,8 @@
4141 * (bug 22709) IIS7 mishandles redirects generated by OutputPage::output() when
4242 the URL contains a colon.
4343 * (bug 22353) Categorised recent changes now works again
 44+* (bug 22747) "Reveal my e-mail address in notification e-mails" preference is
 45+ now only displayed when relevant
4446
4547 == API changes in 1.17 ==
4648 * (bug 22738) Allow filtering by action type on query=logevent

Follow-up revisions

RevisionCommit summaryAuthorDate
r63341Follow-up r63340: don't throw a notice if $wgEnotifRevealEditorAddress is falseialex20:55, 6 March 2010

Status & tagging log