r63267 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63266‎ | r63267 | r63268 >
Date:05:27, 5 March 2010
Author:nad
Status:deferred (Comments)
Tags:
Comment:
urlencode edit with form link
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin.php (modified) (history)
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -75,7 +75,7 @@
7676 # Add an "edit with form" action link
7777 if ( $wgRecordAdminEditWithForm ) {
7878 $wgHooks['SkinTemplateTabs'][] = $this;
79 - $qs = "wpType={$this->type}&wpRecord=" . $title->getPrefixedText();
 79+ $qs = "wpType={$this->type}&wpRecord=" . urlencode( $title->getPrefixedText() );
8080 $this->acturl = Title::makeTitle( NS_SPECIAL, 'RecordAdmin' )->getLocalURL( $qs );
8181 }
8282 }
Index: trunk/extensions/RecordAdmin/RecordAdmin.php
@@ -11,7 +11,7 @@
1212 * @licence GNU General Public Licence 2.0 or later
1313 */
1414
15 -define( 'RECORDADMIN_VERSION', '0.11.5, 2010-03-04' );
 15+define( 'RECORDADMIN_VERSION', '0.11.6, 2010-03-05' );
1616
1717 $wgRecordAdminUseNamespaces = false; # Whether record articles should be in a namespace of the same name as their type
1818 $wgRecordAdminCategory = 'Records'; # Category containing record types

Comments

#Comment by Platonides (talk | contribs)   16:35, 5 March 2010

What about using ->getLocalURL( array( "wpType"=>$this->type, "wpRecord"=> $title->getPrefixedText() ) ) ?

Status & tagging log