r63213 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r63212‎ | r63213 | r63214 >
Date:18:18, 3 March 2010
Author:platonides
Status:reverted
Tags:
Comment:
Escape the caret under Windows, since that's a special character for cmd shell.
Bug 13518 - <math> does not work (wrong shell escaping under Windows)
Modified paths:
  • /trunk/phase3/includes/Math.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Math.php
——@@ -67,7 +67,7 @@
6868
6969 if ( wfIsWindows() ) {
7070 # Invoke it within cygwin sh, because texvc expects sh features in its default shell
71 - $cmd = 'sh -c ' . wfEscapeShellArg( $cmd );
 71+ $cmd = 'sh -c ' . wfEscapeShellArg( str_replace( "^", "^^", $cmd ) );
7272 }
7373
7474 wfDebug( "TeX: $cmd\n" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r63214Follow-up r63213. Move it to wfEscapeShellArg, which is the proper place.platonides18:22, 3 March 2010
r69201Revert r63213, r63214 per CR comment on r63214, doesn't match documented cmd....tstarling06:54, 9 July 2010

Status & tagging log