r62952 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62951‎ | r62952 | r62953 >
Date:11:20, 25 February 2010
Author:happydog
Status:ok
Tags:
Comment:
CodeReview: Changed NULL to null, as per NikeRabbit's comment for r62934 (http://www.mediawiki.org/wiki/Special:Code/MediaWiki/62934#c6009)
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -69,8 +69,8 @@
7070 * i.e. "r123" instead of 123.
7171 * May be called statically if you pass the $id in.
7272 */
73 - public function getIdString( $id = NULL ) {
74 - if ( $id === NULL ) {
 73+ public function getIdString( $id = null ) {
 74+ if ( $id === null ) {
7575 $id = $this->getId();
7676 }
7777 return $this->mRepo->getRevIdString( $id );
@@ -84,8 +84,8 @@
8585 * confusing (e.g. in e-mails, page titles etc.). If only one repository is
8686 * defined then this returns the same as getIdString() as there is no ambiguity.
8787 */
88 - public function getIdStringUnique( $id = NULL ) {
89 - if ( $id === NULL ) {
 88+ public function getIdStringUnique( $id = null ) {
 89+ if ( $id === null ) {
9090 $id = $this->getId();
9191 }
9292 return $this->mRepo->getRevIdStringUnique( $id );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62934CodeReview: Modified the method we use to output the revision ID. If more th...happydog18:50, 24 February 2010

Status & tagging log