r62905 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62904‎ | r62905 | r62906 >
Date:02:44, 24 February 2010
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Fixed skipAndAppend() $len default value
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeCommentLinker.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeCommentLinker.php
@@ -117,7 +117,7 @@
118118 }
119119
120120 // like strcspn() but adds the skipped chars to $ret
121 - private function skipAndAppend( &$ret, $text, $search, $start, $len = NULL ) {
 121+ private function skipAndAppend( &$ret, $text, $search, $start, $len = -1 ) {
122122 $skipCount = 0;
123123 if( $start < strlen($text) ) {
124124 $skipCount = strcspn( $text, $search, $start, $len );

Follow-up revisions

RevisionCommit summaryAuthorDate
r62908MFT r62905aaron05:38, 24 February 2010

Comments

#Comment by Aaron Schulz (talk | contribs)   02:47, 24 February 2010

Fix for r62727

Status & tagging log