r62886 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62885‎ | r62886 | r62887 >
Date:18:40, 23 February 2010
Author:siebrand
Status:ok
Tags:
Comment:
Follow-up to r62859: trying to fix Error: 1052 Column 'up_user' in on clause is ambiguous
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/NewMessagesController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/NewMessagesController.php
@@ -275,8 +275,8 @@
276276 $join_conds[$tableNameUserProperties . ' as tc_prop'] = array(
277277 'left join',
278278 array(
279 - 'up_user=user_id',
280 - 'up_property' => 'timecorrection',
 279+ 'tc_prop.up_user=user_id',
 280+ 'tc_prop.up_property' => 'timecorrection',
281281 )
282282 );
283283
@@ -286,8 +286,8 @@
287287 $join_conds[$tableNameUserProperties . ' as l_prop'] = array(
288288 'left join',
289289 array(
290 - 'up_user=user_id',
291 - 'up_property' => 'language',
 290+ 'l_prop.up_user=user_id',
 291+ 'l_prop.up_property' => 'language',
292292 )
293293 );
294294 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r63620MFT r62859, r62886: DB query error for installations with a table prefix.tstarling23:41, 11 March 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62859Fix database error (hopefully). Needs review (also because NewMessages::write...siebrand00:08, 23 February 2010

Status & tagging log