r62835 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62834‎ | r62835 | r62836 >
Date:19:29, 22 February 2010
Author:jeroendedauw
Status:resolved
Tags:
Comment:
replaced spaces in profiling key name
Modified paths:
  • /trunk/extensions/Storyboard/specials/StoryReview/StoryReview_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Storyboard/specials/StoryReview/StoryReview_body.php
@@ -22,7 +22,7 @@
2323 }
2424
2525 public function execute( $language ) {
26 - wfProfileIn('StoryReview special page');
 26+ wfProfileIn('StoryReview-special-page');
2727
2828 global $wgUser;
2929 if ( $wgUser->isAllowed( 'storyreview' ) && !$wgUser->isBlocked() ) {
@@ -34,7 +34,7 @@
3535 $wgOut->permissionRequired( 'storyreview' );
3636 }
3737
38 - wfProfileOut('StoryReview special page');
 38+ wfProfileOut('StoryReview-special-page');
3939 }
4040
4141 private function addOutput() {
@@ -102,9 +102,9 @@
103103 $segments[] = '<tr><td><table width="100%" border="1"><tr><td rowspan="2" width="200px">';
104104 $segments[] = '<img src="http://upload.wikimedia.org/wikipedia/mediawiki/9/99/SemanticMaps.png">'; // TODO: get cropped image here
105105 $segments[] = '</td><td><b>';
106 - $segments[] = $story->story_title;
 106+ $segments[] = htmlspecialchars($story->story_title);
107107 $segments[] = '</b><br />';
108 - $segments[] = $story->story_text;
 108+ $segments[] = htmlspecialchars($story->story_text);
109109 $segments[] = '</td></tr><tr><td align="center" height="35">';
110110 $segments[] = '<button type="button">'; // TODO: figure out how to best update db info (page submit with form or onclick with ajax call?)
111111 $segments[] = wfMsg('storyboard-publish');

Follow-up revisions

RevisionCommit summaryAuthorDate
r62854Cleanup r62802, r62835 use __METHOD__ for wfProfileIn() calls. Also drop no-o...demon22:30, 22 February 2010

Status & tagging log