r62830 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62829‎ | r62830 | r62831 >
Date:18:34, 22 February 2010
Author:jeroendedauw
Status:resolved (Comments)
Tags:
Comment:
Added profiling to story review
Modified paths:
  • /trunk/extensions/Storyboard/specials/StoryReview/StoryReview_body.php (modified) (history)
  • /trunk/extensions/Storyboard/tags/Storysubmission/Storysubmission_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Storyboard/specials/StoryReview/StoryReview_body.php
@@ -4,6 +4,7 @@
55 *
66 * @file StoryReview_body.php
77 * @ingroup Storyboard
 8+ * @ingroup SpecialPage
89 *
910 * @author Jeroen De Dauw
1011 */
@@ -21,6 +22,8 @@
2223 }
2324
2425 public function execute( $language ) {
 26+ wfProfileIn('StoryReview special page');
 27+
2528 global $wgUser;
2629 if ( $wgUser->isAllowed( 'storyreview' ) && !$wgUser->isBlocked() ) {
2730 // If the user has the storyreview permission and is not blocked, show the regular output.
@@ -30,8 +33,10 @@
3134 global $wgOut;
3235 $wgOut->permissionRequired( 'storyreview' );
3336 }
 37+
 38+ wfProfileOut('StoryReview special page');
3439 }
35 -
 40+
3641 private function addOutput() {
3742 global $wgOut;
3843
Index: trunk/extensions/Storyboard/tags/Storysubmission/Storysubmission_body.php
@@ -18,8 +18,11 @@
1919 // http://www.mediawiki.org/wiki/Manual:Forms
2020 // http://www.mediawiki.org/wiki/Manual:Hooks/UnknownAction
2121 public static function render( $input, $args, $parser, $frame ) {
 22+
2223 return <<<END
 24+<form name="storysubmission" action="" method="get">
2325
 26+</form>
2427 END;
2528 }
2629

Comments

#Comment by Catrope (talk | contribs)   19:13, 22 February 2010

Don't use spaces in profiling keys.

#Comment by Jeroen De Dauw (talk | contribs)   19:20, 22 February 2010

Sure. But why not? I've seen such keys in SMW...

#Comment by Jeroen De Dauw (talk | contribs)   22:16, 22 February 2010

Fixed in 62835

Status & tagging log