r62783 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62782‎ | r62783 | r62784 >
Date:18:09, 21 February 2010
Author:ashley
Status:ok (Comments)
Tags:
Comment:
ApiDisabled.php: fix copyright symbol, coding style tweaks
Modified paths:
  • /trunk/phase3/includes/api/ApiDisabled.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiDisabled.php
@@ -1,10 +1,10 @@
22 <?php
33
4 -/*
 4+/**
55 * Created on Sep 25, 2008
66 * API for MediaWiki 1.8+
77 *
8 - * Copyright (C) 2008 Roan Kattouw <Firstname>.<Lastname>@home.nl
 8+ * Copyright © 2008 Roan Kattouw <Firstname>.<Lastname>@home.nl
99 *
1010 * This program is free software; you can redistribute it and/or modify
1111 * it under the terms of the GNU General Public License as published by
@@ -24,7 +24,7 @@
2525
2626 if ( !defined( 'MEDIAWIKI' ) ) {
2727 // Eclipse helper - will be ignored in production
28 - require_once ( "ApiBase.php" );
 28+ require_once( "ApiBase.php" );
2929 }
3030
3131 /**
@@ -40,7 +40,7 @@
4141 class ApiDisabled extends ApiBase {
4242
4343 public function __construct( $main, $action ) {
44 - parent :: __construct( $main, $action );
 44+ parent::__construct( $main, $action );
4545 }
4646
4747 public function execute() {
@@ -52,11 +52,11 @@
5353 }
5454
5555 public function getAllowedParams() {
56 - return array ();
 56+ return array();
5757 }
5858
5959 public function getParamDescription() {
60 - return array ();
 60+ return array();
6161 }
6262
6363 public function getDescription() {
@@ -66,7 +66,7 @@
6767 }
6868
6969 protected function getExamples() {
70 - return array ();
 70+ return array();
7171 }
7272
7373 public function getVersion() {

Comments

#Comment by Reedy (talk | contribs)   18:21, 21 February 2010

Just out of interest, are you doing all these manually?

#Comment by Jack Phoenix (talk | contribs)   19:28, 21 February 2010

Yep.

#Comment by Reedy (talk | contribs)   19:35, 21 February 2010

Lol. Stylize should probably do most of this...

#Comment by Jack Phoenix (talk | contribs)   20:02, 21 February 2010

Simetrical already ran stylize.php against API code -- see r60930.

#Comment by Reedy (talk | contribs)   20:08, 21 February 2010

I know he did, and i've done it a couple of times since to bring it up to date.

I'm not saying stylize does do most of this, i'm saying it should (ie if it doesn't, it should be expanded to do so), as many are probably fairly common mistakes!

Status & tagging log