r62549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62548‎ | r62549 | r62550 >
Date:21:34, 15 February 2010
Author:catrope
Status:ok
Tags:
Comment:
Fix broken comma logic in r62486
Modified paths:
  • /trunk/phase3/includes/api/ApiMain.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiMain.php
@@ -317,11 +317,12 @@
318318 if ( is_bool( $value ) ) {
319319 if ( $value ) {
320320 $ccHeader .= $separator . $name;
 321+ $separator = ', ';
321322 }
322323 } else {
323324 $ccHeader .= $separator . "$name=$value";
 325+ $separator = ', ';
324326 }
325 - $separator = ', ';
326327 }
327328
328329 header( "Cache-Control: $ccHeader" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r62550wmf-deployment: MFT r62549catrope21:37, 15 February 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62486Search suggestion API requests make up a substantial portion of our total apa...tstarling23:52, 14 February 2010

Status & tagging log