r62530 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62529‎ | r62530 | r62531 >
Date:17:47, 15 February 2010
Author:dale
Status:ok (Comments)
Tags:
Comment:
* minor code clean up per cr comments
Modified paths:
  • /branches/js2-work/phase3/includes/api/ApiQueryAllmessages.php (modified) (history)

Diff [purge]

Index: branches/js2-work/phase3/includes/api/ApiQueryAllmessages.php
@@ -90,7 +90,7 @@
9191 $msg = wfMsgExt( $message, array( 'parsemag' ), $args );
9292 } else if ( $args ) {
9393 $msgString = wfMsgGetKey( $message, true, false, false );
94 - $msg = wfMsgReplaceArgs( $msgString, $params['args'] );
 94+ $msg = wfMsgReplaceArgs( $msgString, $args );
9595 }else{
9696 $msg = wfMsgGetKey( $message, true, false, false );
9797 }
@@ -145,10 +145,9 @@
146146 return array (
147147 'messages' => 'Which messages to output. "*" means all messages',
148148 'prop' => 'Which properties to get',
149 - 'enableparser' => 'Set to enable parser, will parses the wikitext of message \n' .
150 - 'Will substitute magic words, handle templates etc.',
151 - 'args' => 'Arguments to be substituted into message. \n' .
152 - 'Will replace $1, $2 with values. ( values are \'|\' separated )',
 149+ 'enableparser' => array('Set to enable parser, will parses the wikitext of message',
 150+ 'Will substitute magic words, handle templates etc'),
 151+ 'args' => 'Arguments to be substituted into message',
153152 'filter' => 'Return only messages that contain this string',
154153 'lang' => 'Return messages in this language',
155154 'from' => 'Return messages starting at this message',

Comments

#Comment by Catrope (talk | contribs)   17:55, 15 February 2010

Looks good, can go into trunk now as far as I'm concerned.

Status & tagging log