r62463 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62462‎ | r62463 | r62464 >
Date:14:43, 14 February 2010
Author:reedy
Status:ok
Tags:
Comment:
Another followup to r62425

Switch another dieUsage to dieUsageMsg

getPossibleErrors to match
Modified paths:
  • /trunk/extensions/LiquidThreads/api/ApiThreadAction.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/api/ApiThreadAction.php
@@ -47,7 +47,7 @@
4848 public function getPossibleErrors() {
4949 return array(
5050 array( 'sessionfailure' ),
51 - array( 'code' => 'action', 'info' => 'missing-param' ),
 51+ array( 'missingparam', 'action' ),
5252 array( 'code' => 'too-many-threads', 'info' => 'You may only split one thread at a time' ),
5353 array( 'code' => 'no-specified-threads', 'info' => 'You must specify a thread to split' ),
5454 array( 'code' => 'already-top-level', 'info' => 'This thread is already a top-level thread.' ),
@@ -116,8 +116,7 @@
117117 }
118118
119119 if ( empty( $params['threadaction'] ) ) {
120 - $this->dieUsage( 'missing-param', 'action' );
121 - return;
 120+ $this->dieUsageMsg( array( 'missingparam', 'action' ) )
122121 }
123122
124123 $allowedAllActions = array( 'markread' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r62470Follow-up r62463: Fix parse errorraymond16:54, 14 February 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62425getPossibleErrors for ApiThreadActionreedy13:50, 13 February 2010

Status & tagging log