r62414 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62413‎ | r62414 | r62415 >
Date:01:38, 13 February 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
4 More dieUsage calls

Bar some from ApiBase.. These are done..
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryDuplicateFiles.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryImages.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryInfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryLangLinks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryLangLinks.php
@@ -116,6 +116,12 @@
117117 public function getDescription() {
118118 return 'Returns all interlanguage links from the given page(s)';
119119 }
 120+
 121+ public function getPossibleErrors() {
 122+ return array_merge( parent::getPossibleErrors(), array(
 123+ array( 'code' => '_badcontinue', 'info' => 'Invalid continue param. You should pass the original value returned by the previous query' ),
 124+ ) );
 125+ }
120126
121127 protected function getExamples() {
122128 return array (
Index: trunk/phase3/includes/api/ApiQueryInfo.php
@@ -596,6 +596,12 @@
597597 public function getDescription() {
598598 return 'Get basic page information such as namespace, title, last touched date, ...';
599599 }
 600+
 601+ public function getPossibleErrors() {
 602+ return array_merge( parent::getPossibleErrors(), array(
 603+ array( 'code' => '_badcontinue', 'info' => 'Invalid continue param. You should pass the original value returned by the previous query' ),
 604+ ) );
 605+ }
600606
601607 protected function getExamples() {
602608 return array (
Index: trunk/phase3/includes/api/ApiQueryDuplicateFiles.php
@@ -148,6 +148,12 @@
149149 public function getDescription() {
150150 return 'List all files that are duplicates of the given file(s).';
151151 }
 152+
 153+ public function getPossibleErrors() {
 154+ return array_merge( parent::getPossibleErrors(), array(
 155+ array( 'code' => '_badcontinue', 'info' => 'Invalid continue param. You should pass the original value returned by the previous query' ),
 156+ ) );
 157+ }
152158
153159 protected function getExamples() {
154160 return array ( 'api.php?action=query&titles=File:Albert_Einstein_Head.jpg&prop=duplicatefiles',
Index: trunk/phase3/includes/api/ApiQueryImages.php
@@ -145,6 +145,12 @@
146146 public function getDescription() {
147147 return 'Returns all images contained on the given page(s)';
148148 }
 149+
 150+ public function getPossibleErrors() {
 151+ return array_merge( parent::getPossibleErrors(), array(
 152+ array( 'code' => '_badcontinue', 'info' => 'Invalid continue param. You should pass the original value returned by the previous query' ),
 153+ ) );
 154+ }
149155
150156 protected function getExamples() {
151157 return array (

Comments

#Comment by Bryan (talk | contribs)   11:17, 20 February 2010

Unfortunately we can't change it anymore, but by is this code called _badcontinue and not just badcontinue?

Status & tagging log