r62358 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62357‎ | r62358 | r62359 >
Date:11:40, 12 February 2010
Author:churchofemacs
Status:ok
Tags:
Comment:
sort of fixing bug 14592: show warning when moving a user page that the user will not be renamed
Modified paths:
  • /trunk/phase3/includes/specials/SpecialMovepage.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -2034,6 +2034,7 @@
20352035 'movepagetext',
20362036 'movepagetalktext',
20372037 'movearticle',
 2038+ 'moveuserpage-warning',
20382039 'movenologin',
20392040 'movenologintext',
20402041 'movenotallowed',
Index: trunk/phase3/includes/specials/SpecialMovepage.php
@@ -131,6 +131,9 @@
132132 </tr>";
133133 $err = '';
134134 } else {
 135+ if ($this->oldTitle->getNamespace() == NS_USER && !$this->oldTitle->isSubpage() ) {
 136+ $wgOut->addWikiMsg( 'moveuserpage-warning' );
 137+ }
135138 $wgOut->addWikiMsg( 'movepagetext' );
136139 $movepagebtn = wfMsg( 'movepagebtn' );
137140 $submitVar = 'wpMove';
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -3039,6 +3039,7 @@
30403040
30413041 In those cases, you will have to move or merge the page manually if desired.",
30423042 'movearticle' => 'Move page:',
 3043+'moveuserpage-warning' => "'''Warning:''' You are about to move a user page. Please note that only the page will be moved and the user will ''not'' be renamed.",
30433044 'movenologin' => 'Not logged in',
30443045 'movenologintext' => 'You must be a registered user and [[Special:UserLogin|logged in]] to move a page.',
30453046 'movenotallowed' => 'You do not have permission to move pages.',

Follow-up revisions

RevisionCommit summaryAuthorDate
r62457Follow-up r62358: Wrap warning message into a div with the generic "error" an...raymond11:36, 14 February 2010
r62714Adding references to r62241 and r62358 to release noteschurchofemacs18:36, 19 February 2010

Status & tagging log