r62338 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62337‎ | r62338 | r62339 >
Date:22:27, 11 February 2010
Author:werdna
Status:ok (Comments)
Tags:
Comment:
LiquidThreads: Add overflow: scroll to lqt-post-wrapper. This is ugly, but not nearly as ugly as a horizontal scrollbar on a large talk page.
Modified paths:
  • /trunk/extensions/LiquidThreads/lqt.css (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.css
@@ -345,6 +345,7 @@
346346
347347 .lqt-post-wrapper {
348348 padding: 0.5em 1em;
 349+ overflow: auto;
349350 }
350351
351352 .lqt-thread-info-panel {

Follow-up revisions

RevisionCommit summaryAuthorDate
r62344Merge the remainder (r62231-r62338) of trunk revisions into LiquidThreads alphawerdna23:29, 11 February 2010

Comments

#Comment by Simetrical (talk | contribs)   20:04, 12 February 2010

Is the typo here in your commit message or your code? You said "scroll" one place and "auto" the other.

#Comment by Tim Starling (talk | contribs)   06:55, 19 February 2010

Since the rest of the commit message says he's getting rid of scroll bars, I would assume that the code is correct.

#Comment by Simetrical (talk | contribs)   18:00, 19 February 2010

Me too, which is why I didn't mark fixme, but I wanted to point it out to be on the safe side.

Status & tagging log