r62331 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62330‎ | r62331 | r62332 >
Date:21:53, 11 February 2010
Author:reedy
Status:ok
Tags:
Comment:
Followup to bryans comment for r62328

Rename possibleErrors to getPossibleErrors
Modified paths:
  • /trunk/phase3/includes/api/ApiBase.php (modified) (history)
  • /trunk/phase3/includes/api/ApiBlock.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiBlock.php
@@ -158,8 +158,8 @@
159159 );
160160 }
161161
162 - public function possibleErrors() {
163 - return array_merge( parent::possibleErrors(), array(
 162+ public function getPossibleErrors() {
 163+ return array_merge( parent::getPossibleErrors(), array(
164164 array( 'missingparam', 'user' ),
165165 array( 'missingparam', 'token' ),
166166 array( 'sessionfailure' ),
Index: trunk/phase3/includes/api/ApiBase.php
@@ -968,7 +968,7 @@
969969 /**
970970 * Returns a list of all possible errors returned by the module
971971 */
972 - public function possibleErrors() {
 972+ public function getPossibleErrors() {
973973 $ret = array( array( 'readrequired' ) );
974974
975975 if ( $this->mustBePosted() ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r62333Update code documentation with Bryans help for r62282 and r62331reedy22:06, 11 February 2010
r62336Fix r62331 - If we renamed a method, we need to to it everywhere!reedy22:22, 11 February 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62328More of bug 18771 - List possible errors in action=paraminfo...reedy21:34, 11 February 2010

Status & tagging log