r62229 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62228‎ | r62229 | r62230 >
Date:09:59, 10 February 2010
Author:mah
Status:ok (Comments)
Tags:
Comment:
follow-up r62164
Modified paths:
  • /trunk/phase3/includes/upload/UploadFromFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadFromFile.php
@@ -2,9 +2,9 @@
33 /**
44 * @file
55 * @ingroup upload
6 - *
 6+ *
77 * @author Bryan Tong Minh
8 - *
 8+ *
99 * Implements regular file uploads
1010 */
1111 class UploadFromFile extends UploadBase {
@@ -14,7 +14,7 @@
1515 $desiredDestName = $request->getText( 'wpDestFile' );
1616 if( !$desiredDestName )
1717 $desiredDestName = $request->getText( 'wpUploadFile' );
18 - return $this->initialize(
 18+ return $this->initializePathInfo(
1919 $desiredDestName,
2020 $request->getFileTempName( 'wpUploadFile' ),
2121 $request->getFileSize( 'wpUploadFile' )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62164follow up r61407...mah03:54, 9 February 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   10:02, 10 February 2010

(hit enter before the full commit msg) Was looking for parent::initialize yesterday, so I missed the instance where initialize() wasn't overridden.

Status & tagging log