r62140 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62139‎ | r62140 | r62141 >
Date:22:01, 8 February 2010
Author:catrope
Status:ok
Tags:
Comment:
OptIn: Show "Leave Beta" link if a user has ANY feature enabled (rather than only displaying it if they have ALL of them). Also don't consider the skin preference for this.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/OptIn/SpecialOptIn.php
@@ -25,11 +25,11 @@
2626 return false;
2727
2828 foreach ( $wgOptInPrefs as $pref => $value ) {
29 - if ( $user->getOption( $pref ) != $value ) {
30 - return false;
 29+ if ( $pref != 'skin' && $user->getOption( $pref ) == $value ) {
 30+ return true;
3131 }
3232 }
33 - return true;
 33+ return false;
3434 }
3535
3636 public static function checkToken() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r62141wmf-deployment: Merge r62140 (OptIn fix) from trunkcatrope22:05, 8 February 2010

Status & tagging log