r62116 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62115‎ | r62116 | r62117 >
Date:04:49, 8 February 2010
Author:werdna
Status:ok
Tags:
Comment:
Make a few more protected functions public, so they can be called from hooks
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -225,7 +225,7 @@
226226 }
227227 }
228228
229 - protected function insertMove( &$s, $rc ) {
 229+ public function insertMove( &$s, $rc ) {
230230 # Diff
231231 $s .= '(' . $this->message['diff'] . ') (';
232232 # Hist
@@ -257,7 +257,7 @@
258258 );
259259 }
260260
261 - protected function insertDateHeader( &$s, $rc_timestamp ) {
 261+ public function insertDateHeader( &$s, $rc_timestamp ) {
262262 global $wgLang;
263263 # Make date header if necessary
264264 $date = $wgLang->date( $rc_timestamp, true, true );
@@ -271,7 +271,7 @@
272272 }
273273 }
274274
275 - protected function insertLog( &$s, $title, $logtype ) {
 275+ public function insertLog( &$s, $title, $logtype ) {
276276 $logname = LogPage::logName( $logtype );
277277 $s .= '(' . $this->skin->link(
278278 $title,
@@ -282,7 +282,7 @@
283283 ) . ')';
284284 }
285285
286 - protected function insertDiffHist( &$s, &$rc, $unpatrolled ) {
 286+ public function insertDiffHist( &$s, &$rc, $unpatrolled ) {
287287 # Diff link
288288 if( $rc->mAttribs['rc_type'] == RC_NEW || $rc->mAttribs['rc_type'] == RC_LOG ) {
289289 $diffLink = $this->message['diff'];
@@ -322,7 +322,7 @@
323323 $s .= ') . . ';
324324 }
325325
326 - protected function insertArticleLink( &$s, &$rc, $unpatrolled, $watched ) {
 326+ public function insertArticleLink( &$s, &$rc, $unpatrolled, $watched ) {
327327 global $wgContLang;
328328 # If it's a new article, there is no diff link, but if it hasn't been
329329 # patrolled yet, we need to give users a way to do so
@@ -363,7 +363,7 @@
364364 $s .= " $articlelink";
365365 }
366366
367 - protected function insertTimestamp( &$s, $rc ) {
 367+ public function insertTimestamp( &$s, $rc ) {
368368 global $wgLang;
369369 $s .= $this->message['semicolon-separator'] .
370370 $wgLang->time( $rc->mAttribs['rc_timestamp'], true, true ) . ' . . ';
@@ -380,7 +380,7 @@
381381 }
382382
383383 /** insert a formatted action */
384 - protected function insertAction( &$s, &$rc ) {
 384+ public function insertAction( &$s, &$rc ) {
385385 if( $rc->mAttribs['rc_type'] == RC_LOG ) {
386386 if( $this->isDeleted( $rc, LogPage::DELETED_ACTION ) ) {
387387 $s .= ' <span class="history-deleted">' . wfMsgHtml( 'rev-deleted-event' ) . '</span>';
@@ -392,7 +392,7 @@
393393 }
394394
395395 /** insert a formatted comment */
396 - protected function insertComment( &$s, &$rc ) {
 396+ public function insertComment( &$s, &$rc ) {
397397 if( $rc->mAttribs['rc_type'] != RC_MOVE && $rc->mAttribs['rc_type'] != RC_MOVE_OVER_REDIRECT ) {
398398 if( $this->isDeleted( $rc, Revision::DELETED_COMMENT ) ) {
399399 $s .= ' <span class="history-deleted">' . wfMsgHtml( 'rev-deleted-comment' ) . '</span>';

Follow-up revisions

RevisionCommit summaryAuthorDate
r62117Merge r62116werdna04:51, 8 February 2010

Status & tagging log