r62043 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62042‎ | r62043 | r62044 >
Date:19:25, 5 February 2010
Author:tparscal
Status:ok
Tags:
Comment:
Dropped support for Safari 3 for now, until problems therein and be solved.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -72,7 +72,7 @@
7373 array( 'src' => 'js/plugins/jquery.namespaceSelect.js', 'version' => 1 ),
7474 array( 'src' => 'js/plugins/jquery.suggestions.js', 'version' => 7 ),
7575 array( 'src' => 'js/plugins/jquery.textSelection.js', 'version' => 27 ),
76 - array( 'src' => 'js/plugins/jquery.wikiEditor.js', 'version' => 106 ),
 76+ array( 'src' => 'js/plugins/jquery.wikiEditor.js', 'version' => 107 ),
7777 array( 'src' => 'js/plugins/jquery.wikiEditor.highlight.js', 'version' => 29 ),
7878 array( 'src' => 'js/plugins/jquery.wikiEditor.toolbar.js', 'version' => 47 ),
7979 array( 'src' => 'js/plugins/jquery.wikiEditor.dialogs.js', 'version' => 12 ),
@@ -82,10 +82,10 @@
8383 array( 'src' => 'js/plugins/jquery.wikiEditor.publish.js', 'version' => 2 ),
8484 ),
8585 'combined' => array(
86 - array( 'src' => 'js/plugins.combined.js', 'version' => 224 ),
 86+ array( 'src' => 'js/plugins.combined.js', 'version' => 225 ),
8787 ),
8888 'minified' => array(
89 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 224 ),
 89+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 225 ),
9090 ),
9191 ),
9292 );
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.js
@@ -45,7 +45,7 @@
4646 // Text selection bugs galore - this may be a different situation with the new iframe-based solution
4747 'opera': [['>=', 9.6]],
4848 // This should be checked again, but the usage of Safari 3.0 and lower is so small it's not a priority
49 - 'safari': [['>=', 3.1]]
 49+ 'safari': [['>=', 4]]
5050 },
5151 // Right-to-left languages
5252 'rtl': {
@@ -58,7 +58,7 @@
5959 // Text selection bugs galore - this may be a different situation with the new iframe-based solution
6060 'opera': [['>=', 9.6]],
6161 // This should be checked again, but the usage of Safari 3.0 and lower is so small it's not a priority
62 - 'safari': [['>=', 3.1]]
 62+ 'safari': [['>=', 4]]
6363 }
6464 },
6565 /**
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.js
@@ -6478,7 +6478,7 @@
64796479 // Text selection bugs galore - this may be a different situation with the new iframe-based solution
64806480 'opera': [['>=', 9.6]],
64816481 // This should be checked again, but the usage of Safari 3.0 and lower is so small it's not a priority
6482 - 'safari': [['>=', 3.1]]
 6482+ 'safari': [['>=', 4]]
64836483 },
64846484 // Right-to-left languages
64856485 'rtl': {
@@ -6491,7 +6491,7 @@
64926492 // Text selection bugs galore - this may be a different situation with the new iframe-based solution
64936493 'opera': [['>=', 9.6]],
64946494 // This should be checked again, but the usage of Safari 3.0 and lower is so small it's not a priority
6495 - 'safari': [['>=', 3.1]]
 6495+ 'safari': [['>=', 4]]
64966496 }
64976497 },
64986498 /**
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js
@@ -436,7 +436,7 @@
437437 options.endContainer=options.startContainer;break;case'scrollToCaretPosition':options=$.extend({'force':false},options);break;}
438438 var context=$(this).data('wikiEditor-context');var hasIframe=context!==undefined&&context.$iframe!==undefined;var needSave=false;if(hasIframe&&context.savedSelection!==null){context.fn.restoreSelection();needSave=true;}
439439 retval=(hasIframe?context.fn:fn)[command].call(this,options);if(hasIframe&&needSave){context.fn.saveSelection();}
440 -return retval;};})(jQuery);(function($){$.wikiEditor={'modules':{},'instances':[],'browsers':{'ltr':{'msie':[['>=',7]],'firefox':[['>=',2],['!=','2.0'],['!=','2.0.0.1'],['!=','2.0.0.2'],['!=','2.0.0.3'],['!=','2.0.0.4']],'opera':[['>=',9.6]],'safari':[['>=',3.1]]},'rtl':{'msie':[['>=',8]],'firefox':[['>=',2],['!=','2.0'],['!=','2.0.0.1'],['!=','2.0.0.2'],['!=','2.0.0.3'],['!=','2.0.0.4']],'opera':[['>=',9.6]],'safari':[['>=',3.1]]}},'imgPath':wgScriptPath+'/extensions/UsabilityInitiative/images/wikiEditor/','isSupported':function(){if(typeof $.wikiEditor.supported!='undefined'){return $.wikiEditor.supported;}
 440+return retval;};})(jQuery);(function($){$.wikiEditor={'modules':{},'instances':[],'browsers':{'ltr':{'msie':[['>=',7]],'firefox':[['>=',2],['!=','2.0'],['!=','2.0.0.1'],['!=','2.0.0.2'],['!=','2.0.0.3'],['!=','2.0.0.4']],'opera':[['>=',9.6]],'safari':[['>=',4]]},'rtl':{'msie':[['>=',8]],'firefox':[['>=',2],['!=','2.0'],['!=','2.0.0.1'],['!=','2.0.0.2'],['!=','2.0.0.3'],['!=','2.0.0.4']],'opera':[['>=',9.6]],'safari':[['>=',4]]}},'imgPath':wgScriptPath+'/extensions/UsabilityInitiative/images/wikiEditor/','isSupported':function(){if(typeof $.wikiEditor.supported!='undefined'){return $.wikiEditor.supported;}
441441 if(!($.browser.name in $.wikiEditor.browsers[$('body').is('.rtl')?'rtl':'ltr'])){return $.wikiEditor.supported=true;}
442442 var browser=$.wikiEditor.browsers[$('body').is('.rtl')?'rtl':'ltr'][$.browser.name];for(var condition in browser){var op=browser[condition][0];var val=browser[condition][1];if(typeof val=='string'){if(!(eval('$.browser.version'+op+'"'+val+'"'))){return $.wikiEditor.supported=false;}}else if(typeof val=='number'){if(!(eval('$.browser.versionNumber'+op+val))){return $.wikiEditor.supported=false;}}}
443443 return $.wikiEditor.supported=true;},'autoMsg':function(object,property){if(typeof property=='object'){for(var i in property){if(property[i]in object||property[i]+'Msg'in object){property=property[i];break;}}}

Follow-up revisions

RevisionCommit summaryAuthorDate
r62055For usability initiative: merge r62041, r62043werdna00:44, 6 February 2010

Status & tagging log