r62022 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r62021‎ | r62022 | r62023 >
Date:13:43, 5 February 2010
Author:raymond
Status:reverted (Comments)
Tags:
Comment:
Fix tabindex for summaryfield. The textbox area has tabindex 1 already.
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
——@@ -1549,7 +1549,7 @@
15501550 $inputAttrs = ( is_array($inputAttrs) ? $inputAttrs : array() ) + array(
15511551 'id' => 'wpSummary',
15521552 'maxlength' => '200',
1553 - 'tabindex' => '1',
 1553+ 'tabindex' => '2',
15541554 'size' => 60,
15551555 'spellcheck' => 'true',
15561556 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r62249Revert r62022: breaks tab order on section=new edits, see also CR.catrope15:15, 10 February 2010

Comments

#Comment by Catrope (talk | contribs)   16:34, 8 February 2010

This is not necessary. Non-unique tabindexes are perfectly legal: the document order is used to break ties.

#Comment by Catrope (talk | contribs)   15:06, 10 February 2010

I'll have to eat my words here: apparently this is necessary to make r62139 and friends work.

#Comment by Catrope (talk | contribs)   15:20, 10 February 2010

And I'll have to eat *that* as well: it *is* necessary to set tabindex=1 on both wpTextbox1 and wpSummary, because they don't always appear in the same order (wpSummary appears before wpTextbox1 on section=new). Reverted in r62249.

Status & tagging log