r61909 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61908‎ | r61909 | r61910 >
Date:05:42, 3 February 2010
Author:tstarling
Status:ok (Comments)
Tags:
Comment:
Followup to r61905: remove parser tests for ex-feature.
Modified paths:
  • /trunk/phase3/maintenance/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.txt
@@ -7609,184 +7609,6 @@
76107610 <a href="https://www.mediawiki.org/wiki/Main_Page#section" title="Main Page">#section</a>
76117611 !! end
76127612
7613 -Note: some elements used in these Microdata examples don't work, like <img>
7614 -and <time>.
7615 -!! test
7616 -Microdata: vCard example from spec (with some tweaks)
7617 -!! input
7618 -<div id="jack" itemscope itemtype="http://microformats.org/profile/hcard">
7619 -<h1 itemprop="fn">Jack Bauer</h1>
7620 -<img itemprop="photo" alt="" src="jack-bauer.jpg">
7621 -<p itemprop="org" itemscope>
7622 -<span itemprop="organization-name">Counter-Terrorist Unit</span>
7623 -(<span itemprop="organization-unit">Los Angeles Division</span>)
7624 -</p>
7625 -<p>
7626 -<span itemprop="adr" itemscope>
7627 -<span itemprop="street-address">10201 W. Pico Blvd.</span><br>
7628 -<span itemprop="locality">Los Angeles</span>,
7629 -<span itemprop="region">CA</span>
7630 -<span itemprop="postal-code">90064</span><br>
7631 -<span itemprop="country-name">United States</span><br>
7632 -</span>
7633 -<span itemprop="geo">34.052339;-118.410623</span>
7634 -</p>
7635 -<h2>Assorted Contact Methods</h2>
7636 -<ul>
7637 -<li itemprop="tel" itemscope>
7638 -<span itemprop="value">+1 (310) 597 3781</span> <span itemprop="type">work</span>
7639 -<meta itemprop="type" content="pref">
7640 -</li>
7641 -<li><a itemprop="url" href="http://en.wikipedia.org/wiki/Jack_Bauer">I'm on Wikipedia</a>
7642 -so you can leave a message on my user talk page.</li>
7643 -<li><a itemprop="url" href="http://www.jackbauerfacts.com/">Jack Bauer Facts</a></li>
7644 -<li itemprop="email"><a href="mailto:j.bauer@la.ctu.gov.invalid">j.bauer@la.ctu.gov.invalid</a></li>
7645 -<li itemprop="tel" itemscope>
7646 -<span itemprop="value">+1 (310) 555 3781</span> <span>
7647 -<meta itemprop="type" content="cell">mobile phone</span>
7648 -</li>
7649 -</ul>
7650 -<p itemprop="note">If I'm out in the field, you may be better off contacting <span
7651 -itemprop="agent" itemscope itemtype="http://microformats.org/profile/hcard"><a
7652 -itemprop="email" href="mailto:c.obrian@la.ctu.gov.invalid"><span
7653 -itemprop="fn">Chloe O'Brian</span></a></span> if it's about work, or ask <span
7654 -itemprop="agent">Tony Almeida</span> if you're interested in the CTU five-a-side football team we're trying to get going.</p>
7655 -<span itemprop="rev" itemscope>
7656 -<meta itemprop="type" content="date-time">
7657 -<meta itemprop="value" content="2008-07-20T21:00:00+0100">
7658 -</span>
7659 -<p itemprop="tel" itemscope><strong>Update!</strong>
7660 -My new <span itemprop="type">home</span> phone number is
7661 -<span itemprop="value">01632 960 123</span>.
7662 -</p>
7663 -</div>
7664 -!! result
7665 -<div id="jack" itemscope="itemscope" itemtype="http&#58;//microformats.org/profile/hcard">
7666 -<h1 itemprop="fn"> <span class="mw-headline" id="Jack_Bauer">Jack Bauer</span></h1>
7667 -<p>&lt;img itemprop="photo" alt="" src="jack-bauer.jpg"&gt;
7668 -</p>
7669 -<p itemprop="org" itemscope="itemscope">
7670 -<span itemprop="organization-name">Counter-Terrorist Unit</span>
7671 -(<span itemprop="organization-unit">Los Angeles Division</span>)
7672 -</p>
7673 -<p>
7674 -<span itemprop="adr" itemscope="itemscope">
7675 -<span itemprop="street-address">10201 W. Pico Blvd.</span><br />
7676 -<span itemprop="locality">Los Angeles</span>,
7677 -<span itemprop="region">CA</span>
7678 -<span itemprop="postal-code">90064</span><br />
7679 -<span itemprop="country-name">United States</span><br />
7680 -</span>
7681 -<span itemprop="geo">34.052339;-118.410623</span>
7682 -</p>
7683 -<h2> <span class="mw-headline" id="Assorted_Contact_Methods">Assorted Contact Methods</span></h2>
7684 -<ul>
7685 -<li itemprop="tel" itemscope="itemscope">
7686 -<span itemprop="value">+1 (310) 597 3781</span> <span itemprop="type">work</span>
7687 -&lt;meta itemprop="type" content="pref"&gt;
7688 -</li>
7689 -<li><a href="http://en.wikipedia.org/wiki/Jack_Bauer" class="external " itemprop="url">I'm on Wikipedia</a>
7690 -so you can leave a message on my user talk page.</li>
7691 -<li><a href="http://www.jackbauerfacts.com/" class="external " itemprop="url">Jack Bauer Facts</a></li>
7692 -<li itemprop="email"><a href="mailto:j.bauer@la.ctu.gov.invalid" class="external ">j.bauer@la.ctu.gov.invalid</a></li>
7693 -<li itemprop="tel" itemscope="itemscope">
7694 -<span itemprop="value">+1 (310) 555 3781</span> <span>
7695 -&lt;meta itemprop="type" content="cell"&gt;mobile phone</span>
7696 -</li>
7697 -</ul>
7698 -<p itemprop="note">If I'm out in the field, you may be better off contacting <span itemprop="agent" itemscope="itemscope" itemtype="http&#58;//microformats.org/profile/hcard"><a href="mailto:c.obrian@la.ctu.gov.invalid" class="external " itemprop="email"><span itemprop="fn">Chloe O'Brian</span></a></span> if it's about work, or ask <span itemprop="agent">Tony Almeida</span> if you're interested in the CTU five-a-side football team we're trying to get going.</p>
7699 -<p><span itemprop="rev" itemscope="itemscope">
7700 -&lt;meta itemprop="type" content="date-time"&gt;
7701 -&lt;meta itemprop="value" content="2008-07-20T21:00:00+0100"&gt;
7702 -</span>
7703 -</p>
7704 -<p itemprop="tel" itemscope="itemscope"><strong>Update!</strong>
7705 -My new <span itemprop="type">home</span> phone number is
7706 -<span itemprop="value">01632 960 123</span>.
7707 -</p>
7708 -</div>
7709 -
7710 -!! end
7711 -
7712 -!! test
7713 -Microdata: vEvent example from spec (with some tweaks)
7714 -!! input
7715 -<div itemscope itemtype="http://microformats.org/profile/hcalendar#vevent">
7716 -<p>I'm going to
7717 -<strong itemprop="summary">Bluesday Tuesday: Money Road</strong>,
7718 -<time itemprop="dtstart" datetime="2009-05-05T19:00:00Z">May 5th at 7pm</time>
7719 -to <time itemprop="dtend" content="2009-05-05T21:00:00Z">9pm</time>,
7720 -at <span itemprop="location">The RoadHouse</span>!</p>
7721 -<p><a href="http://livebrum.co.uk/2009/05/05/bluesday-tuesday-money-road"
7722 -itemprop="url">See this event on livebrum.co.uk</a>.</p>
7723 -<meta itemprop="description" content="via livebrum.co.uk">
7724 -</div>
7725 -!! result
7726 -<div itemscope="itemscope" itemtype="http&#58;//microformats.org/profile/hcalendar#vevent">
7727 -<p>I'm going to
7728 -<strong itemprop="summary">Bluesday Tuesday: Money Road</strong>,
7729 -&lt;time itemprop="dtstart" datetime="2009-05-05T19:00:00Z"&gt;May 5th at 7pm&lt;/time&gt;
7730 -to &lt;time itemprop="dtend" content="2009-05-05T21:00:00Z"&gt;9pm&lt;/time&gt;,
7731 -at <span itemprop="location">The RoadHouse</span>!</p>
7732 -<p><a href="http://livebrum.co.uk/2009/05/05/bluesday-tuesday-money-road" class="external " itemprop="url">See this event on livebrum.co.uk</a>.</p>
7733 -<p>&lt;meta itemprop="description" content="via livebrum.co.uk"&gt;
7734 -</p>
7735 -</div>
7736 -
7737 -!! end
7738 -
7739 -!! test
7740 -Microdata: license example from spec (with some tweaks)
7741 -!! input
7742 -<div itemscope itemtype="http://n.whatwg.org/work">
7743 -<img itemprop="work" src="mypond.jpeg">
7744 -<p><cite itemprop="title">My Pond</cite></p>
7745 -<p><small>Licensed under the <a itemprop="license"
7746 -href="http://creativecommons.org/licenses/by-sa/3.0/us/">Creative
7747 -Commons Attribution-Share Alike 3.0 United States License</a>
7748 -and the <a itemprop="license"
7749 -href="http://www.opensource.org/licenses/mit-license.php">MIT
7750 -license</a>.</small></p>
7751 -</div>
7752 -!! result
7753 -<div itemscope="itemscope" itemtype="http&#58;//n.whatwg.org/work">
7754 -<p>&lt;img itemprop="work" src="mypond.jpeg"&gt;
7755 -</p>
7756 -<p><cite itemprop="title">My Pond</cite></p>
7757 -<p><small>Licensed under the <a href="http://creativecommons.org/licenses/by-sa/3.0/us/" class="external " itemprop="license">Creative
7758 -Commons Attribution-Share Alike 3.0 United States License</a>
7759 -and the <a href="http://www.opensource.org/licenses/mit-license.php" class="external " itemprop="license">MIT
7760 -license</a>.</small></p>
7761 -</div>
7762 -
7763 -!! end
7764 -
7765 -!! test
7766 -Microdata: license example from spec with bad itemtype
7767 -!! input
7768 -<div itemscope itemtype="http://nonstandard.invalid/">
7769 -<img itemprop="work" src="mypond.jpeg">
7770 -<p><cite itemprop="title">My Pond</cite></p>
7771 -<p><small>Licensed under the <a itemprop="license"
7772 -href="http://creativecommons.org/licenses/by-sa/3.0/us/">Creative
7773 -Commons Attribution-Share Alike 3.0 United States License</a>
7774 -and the <a itemprop="license"
7775 -href="http://www.opensource.org/licenses/mit-license.php">MIT
7776 -license</a>.</small></p>
7777 -</div>
7778 -!! result
7779 -<div>
7780 -<p>&lt;img itemprop="work" src="mypond.jpeg"&gt;
7781 -</p>
7782 -<p><cite itemprop="title">My Pond</cite></p>
7783 -<p><small>Licensed under the <a href="http://creativecommons.org/licenses/by-sa/3.0/us/" class="external " itemprop="license">Creative
7784 -Commons Attribution-Share Alike 3.0 United States License</a>
7785 -and the <a href="http://www.opensource.org/licenses/mit-license.php" class="external " itemprop="license">MIT
7786 -license</a>.</small></p>
7787 -</div>
7788 -
7789 -!! end
7790 -
77917613 !!article
77927614 MediaWiki:bad image list
77937615 !!text

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61905Remove <a> tag hook for now, pending resolution of implementation issues as d...tstarling05:07, 3 February 2010

Comments

#Comment by Simetrical (talk | contribs)   19:03, 4 February 2010

This isn't actually an ex-feature – microdata works without <a>. But since it's now disabled by default (r61985), and doesn't look likely to get enabled anytime soon, we may as well leave them out, I guess.

Status & tagging log