r61907 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61906‎ | r61907 | r61908 >
Date:05:32, 3 February 2010
Author:mah
Status:ok (Comments)
Tags:
Comment:
Bump minimum supported version to 5.1.0
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/maintenance/install-utils.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/install-utils.inc
——@@ -14,11 +14,11 @@
1515
1616 if( !function_exists( 'version_compare' ) ) {
1717 # version_compare was introduced in 4.1.0
18 - echo "Your PHP version is much too old; 4.0.x will _not_ work. 5.0.0 or higher is required. ABORTING.\n";
 18+ echo "Your PHP version is much too old; 4.0.x will _not_ work. 5.1.0 or higher is required. ABORTING.\n";
1919 die( 1 );
2020 }
21 - if( version_compare( phpversion(), '5.0.0' ) < 0 ) {
22 - echo "PHP 5.0.0 or higher is required. If PHP 5 is available only when \n".
 21+ if( version_compare( phpversion(), '5.1.0' ) < 0 ) {
 22+ echo "PHP 5.1.0 or higher is required. If PHP 5 is available only when \n".
2323 "PHP files have a .php5 extension, please navigate to <a href=\"index.php5\">index.php5</a> \n".
2424 "to continue installation. ABORTING.\n";
2525 die( 1 );
Index: trunk/phase3/RELEASE-NOTES
——@@ -867,12 +867,8 @@
868868
869869 == Compatibility ==
870870
871 -MediaWiki 1.16 requires PHP 5 (5.2 recommended). PHP 4 is no longer supported.
 871+MediaWiki 1.16 requires PHP 5.1 (5.2 recommended). PHP 4 is no longer supported.
872872
873 -PHP 5.0.x fails on 64-bit systems due to serious bugs with array processing:
874 -http://bugs.php.net/bug.php?id=34879
875 -Upgrade affected systems to PHP 5.1 or higher.
876 -
877873 MySQL 3.23.x is no longer supported; some older hosts may need to upgrade.
878874 At this time we still recommend 4.0, but 4.1/5.0 will work fine in most cases.
879875

Comments

#Comment by 😂 (talk | contribs)   11:47, 3 February 2010

This is official now? I know some stuff probably only works on 5.1 and above, but we're now marking it a hard requirement?

#Comment by MaxSem (talk | contribs)   11:53, 3 February 2010

If supporting 5.0 realy makes no sense, check for 5.0 bug should also be removed from WebStart.php.

#Comment by MarkAHershberger (talk | contribs)   16:31, 3 February 2010

fixed in r61937

#Comment by 😂 (talk | contribs)   11:58, 3 February 2010

Agreed. And it might be worth pushing this off until we branch. Kind of a sneaky change to put in near the end of the development cycle.

#Comment by MarkAHershberger (talk | contribs)   16:10, 3 February 2010

we require date_default_timezone_get/date_default_timezone_set which are 5.1 only. The installer script runs with E_STRICT on which, under 5.0, is insanely noisy.

There may be other problems. This was just what I noticed from trying to run the installer script and, after asking TimStarling if it was a bug or a reason to bump the version, he said "bump the version."

Status & tagging log