r61810 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61809‎ | r61810 | r61811 >
Date:18:51, 1 February 2010
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Allow gender in 'login-userblocked', per request on http://translatewiki.net/wiki/Thread:Support/Login-userblocked
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserlogin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserlogin.php
——@@ -628,7 +628,8 @@
629629 $this->mainLoginForm( wfMsg( 'login-throttled' ) );
630630 break;
631631 case self::USER_BLOCKED:
632 - $this->mainLoginForm( wfMsg( 'login-userblocked' ) );
 632+ $this->mainLoginForm( wfMsgExt( 'login-userblocked',
 633+ array( 'parsemag', 'escape' ), $this->mName ) );
633634 break;
634635 default:
635636 throw new MWException( "Unhandled case value" );

Comments

#Comment by Nikerabbit (talk | contribs)   19:19, 1 February 2010

Why escape? The other ones are not escaped. It would be better if only message keys and params would be passed instead of the actual text.

#Comment by IAlex (talk | contribs)   20:37, 1 February 2010

Some of them are escaped, see the case NOT_EXISTS above.

Status & tagging log