r61806 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61805‎ | r61806 | r61807 >
Date:18:04, 1 February 2010
Author:ialex
Status:ok
Tags:
Comment:
Fixes to OutputPage's documentation
* action=raw -> action=render
* escape tags in setPageTitle()'s documentation so that it's displayed correctly (not treated as real tags)
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -257,7 +257,7 @@
258258 /**
259259 * Set whether the output should only contain the body of the article,
260260 * without any skin, sidebar, etc.
261 - * Used e.g. when calling with "action=raw".
 261+ * Used e.g. when calling with "action=render".
262262 *
263263 * @param $only Boolean: whether to output only the body of the article
264264 */
@@ -451,10 +451,10 @@
452452 }
453453
454454 /**
455 - * "Page title" means the contents of <h1>. It is stored as a valid HTML fragment.
456 - * This function allows good tags like <sup> in the <h1> tag, but not bad tags like <script>.
457 - * This function automatically sets <title> to the same content as <h1> but with all tags removed.
458 - * Bad tags that were escaped in <h1> will still be escaped in <title>, and good tags like <i> will be dropped entirely.
 455+ * "Page title" means the contents of \<h1\>. It is stored as a valid HTML fragment.
 456+ * This function allows good tags like \<sup\> in the \<h1\> tag, but not bad tags like \<script\>.
 457+ * This function automatically sets \<title\> to the same content as \<h1\> but with all tags removed.
 458+ * Bad tags that were escaped in \<h1\> will still be escaped in \<title\>, and good tags like \<i\> will be dropped entirely.
459459 */
460460 public function setPageTitle( $name ) {
461461 # change "<script>foo&bar</script>" to "&lt;script&gt;foo&amp;bar&lt;/script&gt;"

Follow-up revisions

RevisionCommit summaryAuthorDate
r61862Follow-up r61806: also escape tag in getPageTitle()ialex16:26, 2 February 2010

Status & tagging log