r61764 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61763‎ | r61764 | r61765 >
Date:23:10, 31 January 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Rem extra brace from r61761
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryRecentChanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRecentChanges.php
——@@ -350,7 +350,7 @@
351351 $vals['timestamp'] = wfTimestamp( TS_ISO_8601, $row->rc_timestamp );
352352
353353 /* Add edit summary / log summary. */
354 - if ( $this->fld_comment && isset( $row->rc_comment ) ) {
 354+ if ( $this->fld_comment && isset( $row->rc_comment ) )
355355 $vals['comment'] = $row->rc_comment;
356356
357357 if ( $this->fld_parsedcomment && isset( $row->rc_comment ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61761Finish (bug 18427) Comment (edit summary) parser option for API...reedy23:06, 31 January 2010

Comments

#Comment by Siebrand (talk | contribs)   00:03, 1 February 2010

Please check Manual:Coding_conventions#Braceless_control_structures. This is advised against.

#Comment by Reedy (talk | contribs)   00:48, 1 February 2010

This brace was erroneous, and hence removed..

Quite a few in the API that are like this. If the MoS dictates that's the case, it'd be worth going through and tidying them up.

Noted, thanks

Status & tagging log