r61656 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61655‎ | r61656 | r61657 >
Date:08:13, 29 January 2010
Author:mah
Status:ok (Comments)
Tags:
Comment:
follow up r61319
took out the ".." but otherwise left it the same. On my system, this
installs an SQLite file in $IP/config/data by default using the web
installer. Setting it to "$IP/../data" presents the user with the
/full/path/to/the/MW/../data which seemed more confusing to me.
Modified paths:
  • /trunk/phase3/config/Installer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/config/Installer.php
——@@ -644,7 +644,7 @@
645645 $conf->DBpgschema = importPost( "DBpgschema", "mediawiki" );
646646
647647 ## SQLite specific
648 - $conf->SQLiteDataDir = importPost( "SQLiteDataDir", '../data' );
 648+ $conf->SQLiteDataDir = importPost( "SQLiteDataDir", "$IP/../data" );
649649
650650 ## MSSQL specific
651651 // We need a second field so it doesn't overwrite the MySQL one
——@@ -1665,8 +1665,7 @@
16661666 ?></div>
16671667 <div class="config-desc">
16681668 <p>SQLite stores table data into files in the
1669 - filesystem. By default the path is the "data"
1670 - directory in your document root.</p>
 1669+ filesystem.</p>
16711670
16721671 <p>This directory must exist and be writable by the web server.</p>
16731672 </div>

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61319Fix up data directory sniffing for sqlite. Touch up description of...mah00:00, 21 January 2010

Comments

#Comment by Tim Starling (talk | contribs)   01:58, 3 February 2010

You can use realpath() to remove the dots if you like.

#Comment by Tim Starling (talk | contribs)   01:59, 3 February 2010

You can use realpath() to remove the dots if you like.

#Comment by Tim Starling (talk | contribs)   02:33, 3 February 2010

You can use realpath() to remove the dots if you like.

#Comment by Tim Starling (talk | contribs)   03:34, 3 February 2010

Sorry, got a squid error message and hit refresh twice.

Status & tagging log