r61580 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61579‎ | r61580 | r61581 >
Date:17:11, 27 January 2010
Author:grondin
Status:deferred (Comments)
Tags:
Comment:
Fixed wrong call SpecialRecordAdmin::expandTag() function (RecordAdmin extension)
Fixed wrong call wfNewsFeedLinkTag() function (News extension)
Correcting third parameter (as not a reference)
Modified paths:
  • /trunk/extensions/News/News.php (modified) (history)
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -1005,7 +1005,7 @@
10061006 /**
10071007 * If a record was created by a public form, make last 5 digits of ID available via a tag
10081008 */
1009 - function expandTag( $text, $argv, &$parser ) {
 1009+ function expandTag( $text, $argv, $parser ) {
10101010 $parser->mOutput->mCacheTime = -1;
10111011 return $this->guid ? substr( $this->guid, -5 ) : '';
10121012 }
Index: trunk/extensions/News/News.php
@@ -73,7 +73,7 @@
7474 return $html;
7575 }
7676
77 -function wfNewsFeedLinkTag( $linktext, $argv, &$parser ) {
 77+function wfNewsFeedLinkTag( $linktext, $argv, $parser ) {
7878 return NewsRenderer::renderFeedLink($linktext, $argv, $parser);
7979 }
8080

Comments

#Comment by Grondin (talk | contribs)   20:53, 27 January 2010

See for the same problem r61252

Status & tagging log